Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support vpc-<uuid> in target group binding vpc-id validation #3845

Merged
merged 2 commits into from
Sep 23, 2024
Merged

feat: support vpc-<uuid> in target group binding vpc-id validation #3845

merged 2 commits into from
Sep 23, 2024

Conversation

khizunov
Copy link
Contributor

@khizunov khizunov commented Sep 8, 2024 •
edited
Loading

Issue

#3839

Description

Due to the changes introduced in this PR, the AWS Load Balancer Controller has dropped support for AWS API-compatible solutions. The current PR specifically addresses a use case that involves supporting the VPC ID format as vpc-.

In addition:
Enhanced the VpcID validation in targetgroupbinding_validator.go by introducing specific error messages and validations for different VpcID formats. Added new test cases in targetgroupbinding_validator_test.go to verify the correctness and robustness of the validation logic.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 8, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @khizunov. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 8, 2024
@khizunov khizunov changed the title fixes #3839 support vpc-<uuid> in target groups binding validation fixes #3839 support vpc-<uuid> in target groups vpc-id binding validation Sep 8, 2024
@khizunov khizunov changed the title fixes #3839 support vpc-<uuid> in target groups vpc-id binding validation fixes #3839 support vpc-<uuid> in target groups binding vpc-id validation Sep 8, 2024
@khizunov khizunov changed the title fixes #3839 support vpc-<uuid> in target groups binding vpc-id validation fixes #3839 support vpc-<uuid> in target group binding vpc-id validation Sep 8, 2024
@khizunov khizunov changed the title fixes #3839 support vpc-<uuid> in target group binding vpc-id validation support vpc-<uuid> in target group binding vpc-id validation Sep 9, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Sep 9, 2024
@khizunov khizunov changed the title support vpc-<uuid> in target group binding vpc-id validation feat: support vpc-<uuid> in target group binding vpc-id validation Sep 9, 2024
@khizunov khizunov marked this pull request as ready for review September 9, 2024 05:41
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 9, 2024
@khizunov
Copy link
Contributor Author

khizunov commented Sep 9, 2024

@shraddhabang @andreybutenko

@shraddhabang
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 9, 2024
@khizunov
Copy link
Contributor Author

@shraddhabang tests seems to be passed, what are the further steps?

@shraddhabang
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2024
@khizunov
Copy link
Contributor Author

@shraddhabang sorry for bothering you, do you know who should approve?

@shraddhabang
Copy link
Collaborator

@oliviassss @M00nF1sh Can you please take a look at this PR?

@khizunov
Copy link
Contributor Author

Hello @oliviassss @M00nF1sh, just checking in to see if you’ve had a chance to review this PR. Let me know if there’s anything I can improve.

@oliviassss oliviassss added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Sep 23, 2024
@oliviassss
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khizunov, oliviassss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2024
@k8s-ci-robot k8s-ci-robot merged commit f7c1b3f into kubernetes-sigs:main Sep 23, 2024
5 checks passed
@shraddhabang shraddhabang mentioned this pull request Sep 30, 2024
Merged
zac-nixon pushed a commit to zac-nixon/aws-load-balancer-controller that referenced this pull request Oct 1, 2024
@khizunov @zac-nixon
feat: support vpc-<uuid> in target group binding vpc-id validation (k…
65537e1 
…ubernetes-sigs#3845)

* support vpc-<uuid> in target groups binding validation

* add VpcID validation associated tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers Awaiting requested review from johngmyers

@M00nF1sh M00nF1sh Awaiting requested review from M00nF1sh

@oliviassss oliviassss Awaiting requested review from oliviassss

Assignees

@shraddhabang shraddhabang

@oliviassss oliviassss

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@khizunov @k8s-ci-robot @shraddhabang @oliviassss