Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade k8s version for clusterctl upgrade spec #2975

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

pydctw
Copy link
Contributor

@pydctw pydctw commented Nov 18, 2021

What type of PR is this?
/kind failing-test

What this PR does / why we need it:
clusterctl v1alpha3 upgrade spec on main is failing with the following message. See failing test

[6] • Failure [847.960 seconds]
[6] [unmanaged] [Cluster API Framework]
[6] /home/prow/go/src/sigs.k8s.io/cluster-api-provider-aws/test/e2e/suites/unmanaged/unmanaged_CAPI_test.go:34
[6]   Clusterctl Upgrade Spec [from v1alpha3]
[6]   /home/prow/go/src/sigs.k8s.io/cluster-api-provider-aws/test/e2e/suites/unmanaged/unmanaged_CAPI_test.go:155
[6]     Should create a management cluster and then upgrade all the providers [It]
[6]     /home/prow/go/pkg/mod/sigs.k8s.io/cluster-api/test@v1.0.1-0.20211111175208-4cc2fce2111a/e2e/clusterctl_upgrade.go:145
[6] 
[6]     failed to run clusterctl init:
      
[6]     Error: unsupported management cluster server version: v1.22.2 - versions greater or equal than v1.22.0 are not supported

Downgrading k8s version to 1.21.6 to fix the failing test and unblock main.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:
An issue is raised in CAPI for a long term solution by @sedefsavas - kubernetes-sigs/cluster-api#5704

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Release note:

None

@k8s-ci-robot k8s-ci-robot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-priority labels Nov 18, 2021
@k8s-ci-robot
Copy link
Contributor

@pydctw: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 18, 2021
@pydctw
Copy link
Contributor Author

pydctw commented Nov 18, 2021

/test pull-cluster-api-provider-aws-e2e

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 18, 2021
@pydctw pydctw changed the title Downgrade k8s version for clusterctl v1alpha3 upgrade spec Downgrade k8s version for clusterctl upgrade spec Nov 19, 2021
@Ankitasw
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2021
@Ankitasw
Copy link
Member

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-priority labels Nov 19, 2021
@sedefsavas
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sedefsavas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2021
@k8s-ci-robot k8s-ci-robot merged commit b4b75e6 into kubernetes-sigs:main Nov 19, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.x milestone Nov 19, 2021
@pydctw pydctw deleted the fix-main-e2e branch January 28, 2022 21:24
richardchen-db pushed a commit to databricks/cluster-api-provider-aws-1 that referenced this pull request Jan 14, 2023
Downgrade k8s version for clusterctl upgrade spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants