Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support explicitly specifying which CLI binaries to invoke #282

Closed
negz opened this issue Jun 22, 2023 · 4 comments · Fixed by #286 or #287
Closed

Support explicitly specifying which CLI binaries to invoke #282

negz opened this issue Jun 22, 2023 · 4 comments · Fixed by #286 or #287

Comments

@negz
Copy link
Contributor

negz commented Jun 22, 2023

The e2e-framework offers packages to help spin up Kind clusters and install Helm charts. These packages wrap the kind and helm CLI tools. (There may be other wrapped CLI tools but I haven't encountered them yet.)

The framework seems to look for these tools with hardcoded binary names (kind, helm) in $PATH. If kind isn't available the framework attempts to install it using go install. If helm isn't available the framework returns an error.

In @crossplane our Makefile handles installation of tools like Kind and Helm, but it doesn't install them in $PATH. We can probably hack around this when running the E2E tests (e.g. add a dir to $PATH and symlink to the tools from that dir) but it would be ideal to be able to pass the path to the binaries as flags.

@negz negz changed the title Support explicitly which CLI binaries to invoke Support explicitly specifying which CLI binaries to invoke Jun 22, 2023
@negz
Copy link
Contributor Author

negz commented Jun 22, 2023

As a side note, it would also be useful to debug log which binaries are being used.

@harshanarayana
Copy link
Contributor

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Jun 26, 2023
@k8s-ci-robot
Copy link
Contributor

@harshanarayana: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@harshanarayana
Copy link
Contributor

I missed taking care of a few items on the previous PR. Need to update a few more bits and then this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants