Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example of how to use e2e framework with real cluster #149

Merged
merged 3 commits into from
Jun 29, 2022
Merged

Add example of how to use e2e framework with real cluster #149

merged 3 commits into from
Jun 29, 2022

Conversation

matrus2
Copy link
Contributor

@matrus2 matrus2 commented Jun 15, 2022

Hi,

I have been struggling for a while on how to execute e2e tests in the real cloud provider cluster. I though it might be useful to extend examples set by this particular use case.

Thanks

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 15, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: matrus2 / name: Bogusz Przybyslawski (94f3551)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 15, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @matrus2!

It looks like this is your first PR to kubernetes-sigs/e2e-framework 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/e2e-framework has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 15, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @matrus2. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Jun 15, 2022
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 15, 2022
vladimirvivien
vladimirvivien reviewed Jun 15, 2022
View reviewed changes
Copy link
Contributor

@vladimirvivien vladimirvivien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great contribution. However, since this project is not using Go workspaces yet, the changes introduce new dependencies for the entire project. I would suggest one the followings:

  1. Just submit a markdown with the code embedded it (recommended)
  2. Submit the code without the changes to mod.go and document how to run it.

@matrus2
Copy link
Contributor Author

matrus2 commented Jun 20, 2022

Hi @vladimirvivien,

Thank you for quick reply and recommendation. I commented out cloud vendor auth dependencies, added description . The example may be still used with self-managed cluster. Please validate if PR is ok now. Thank you

vladimirvivien
vladimirvivien reviewed Jun 21, 2022
View reviewed changes
Copy link
Contributor

@vladimirvivien vladimirvivien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, these changes look great.
I left couple of comments.

examples/real_cluster/README.md Outdated

This package shows how the test framework can be used with a real self-managed or cloud vendor managed cluster (AKS/GKE/EKS), since one may want to launch some tests inside the cluster. This example creates a random namespace, deploys simple deployment and if done removes the namespace.

To properly connect to a cloud provider cluster it is required to import for side effects one of auth module. If testing on self-managed cluster there is no need to include these dependencies.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

module -> modules

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If testing on a self-managed...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

examples/real_cluster/README.md Show resolved Hide resolved
vladimirvivien
vladimirvivien approved these changes Jun 25, 2022
View reviewed changes
Copy link
Contributor

@vladimirvivien vladimirvivien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @matrus2 !!

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 25, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2022
@matrus2
Copy link
Contributor Author

matrus2 commented Jun 27, 2022

Hi @vladimirvivien,

I committed small change to pass CI.

Thanks
Bogusz

@ShwethaKumbla
Copy link
Member

/test pull-e2e-framework-test

ShwethaKumbla
ShwethaKumbla reviewed Jun 29, 2022
View reviewed changes
Copy link
Member

@ShwethaKumbla ShwethaKumbla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShwethaKumbla
Copy link
Member

/test pull-e2e-framework-verify

@ShwethaKumbla
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matrus2, ShwethaKumbla, vladimirvivien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ShwethaKumbla,vladimirvivien]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vladimirvivien
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2022
@k8s-ci-robot k8s-ci-robot merged commit b30bf6e into kubernetes-sigs:main Jun 29, 2022
@matrus2 matrus2 mentioned this pull request Oct 27, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShwethaKumbla ShwethaKumbla ShwethaKumbla left review comments

@vladimirvivien vladimirvivien Awaiting requested review from vladimirvivien

Assignees

@vladimirvivien vladimirvivien

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matrus2 @k8s-ci-robot @ShwethaKumbla @vladimirvivien