-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix RandomName's dash when no prefix provided #327
fix: fix RandomName's dash when no prefix provided #327
Conversation
Hi @pmalek. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
667b3ba
to
98b25b7
Compare
@ShwethaKumbla I've removed my change w.r.t usage of deprecated I'd be happy to resolve that in a separate pr but please advise on the linter issue.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This for this changes @pmalek . Left a minor comment.
pkg/envconf/config_test.go
Outdated
const maxLen = 64 | ||
|
||
t.Run("no prefix yields random name without dash", func(t *testing.T) { | ||
out := RandomName("", int(rand.Int31n(maxLen))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need to use the math.rand
based value for the input? Can it not be a pre-defined number?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Changed to use a constant prefix length
An unrelated test seems to have failed 🤔
|
/retest |
afa8274
to
ba5be0f
Compare
Another unrelated failure :(
/retest |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshanarayana, pmalek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Currently
envconf.RandomName()
return a string with an empty prefix when no prefix was provided even though the godoc states:This PR fixes it by checking if an empty prefix was provided.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., Usage docs, etc.: