-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Godaddy #1924
Godaddy #1924
Conversation
First commit
Welcome @Fred78290! |
/assign @njuettner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I'm fine with it, only some nits. But if you could make it possible somehow I'd suggest using a sdk if possible. This might next improvements or adjustments in the future a bit easier 🙂 .
Co-authored-by: Nick Jüttner <nick@juni.io>
Co-authored-by: Nick Jüttner <nick@juni.io>
Co-authored-by: Nick Jüttner <nick@juni.io>
Co-authored-by: Nick Jüttner <nick@juni.io>
Co-authored-by: Nick Jüttner <nick@juni.io>
Co-authored-by: Nick Jüttner <nick@juni.io>
Strange, I'd already replied but I don't find it. There is any official GoDaddy API SDK supplied by GoDaddy in any language. Only individual implementation. |
Argg closed accidentaly :( |
Hello, is this still being worked on? my team could definitely leverage this functionality. thanks! |
Hello, I'm still waiting for review & approve step. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey cool @Fred78290, sorry for the late response but you PR is not forgotten 😄 .
Thanks for addressing my comments, happy to merge it 🚀 .
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fred78290, njuettner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Adds a provider for GoDaddy's DNS service, using their HTTP API.
This part of code has been fully tested with an app having an ingress
Checklist