-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Powerdns support rrsets with multiple records more smartly #1968
Make Powerdns support rrsets with multiple records more smartly #1968
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @dsalisbury! |
If you had an RRSet that contained multiple records, the provider would end up generating multiple endpoints where really it needs to produce a single endpoint with multiple targets.
d12d956
to
f4a1b67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsalisbury, njuettner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Hey!
I'm not sure if I've overlooked something here but I've written in in #1967 about the problem I saw where external-dns would continually update a zone even when it was already in the correct state.
From my debugging it appears this is down to the way it fetches its Endpoints from the pdns API. I can't see why it's written as it is but I think my change is legit.
I've tweaked the pdns provider so that when it encounters an rrset with multiple records, instead of building one Endpoint per record, it builds a single Endpoint with multiple targets. This stops it from making the same update over and over.
I will add this is my first time writing any Go so please shout at me if I've done something dumb -- even in this small PR!
Fixes #1967
Checklist