-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move from dynectsoap to dynsoap #1985
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @PG2000! |
I signed it |
/assign @njuettner |
@PG2000 to prevent other problems with the maintenance of the library, given that most seems to be generated, can't we just add all the files to ExternalDNS transferring its ownership and remove completely the external dependency? |
@Raffo |
@PG2000 Yes it's not a problem. |
@Raffo i transferred all files to this project. How can i exclude the generated code from code coverage report? |
@Raffo can i help somehow? |
/kind cleanup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PG2000 please review the method comments and align to the go convention as I mentioned in my comment. After you do that we can totally merge this PR!
@Raffo done! |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: PG2000, Raffo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This change removes the use of dynectsoap library from dyn provider since it is not licensed or actively being maintained and is missing the usage of a proxy.
It introduces a similar library https://github.com/PG2000/dynsoap which uses more generated code and has a MIT License
Fixes #1787
Checklist