-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add krb5 realm support #1993
add krb5 realm support #1993
Conversation
Welcome @ba-work! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a comment on validation.
looks like this was handled/merged/copied via #2015, however my PR includes more tests and validation so I'm going to leave it open |
/assign @Raffo |
/kind feature |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ba-work, Raffo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This adds configurable realm support so that the realm and zone are no longer coupled.
Most of the code was already there, looks like this was a small oversight.
I tested this in a real AD environment with success.
This closes #1981.
Checklist