-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to configure k8s event rate limit #2013
Add the ability to configure k8s event rate limit #2013
Conversation
Currently, the minimum delay between 2 kubernetes events handling is hard-coded to 5s. This may cause higher synchronization rates and higher DNS provider API calls when handling an important number of kubernetes events at once. Give the opportunity to configure this delay so service owners can define the acceptable thresholds on their side
/assign @Raffo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tjamet I only have one comment that is basically a refactoring opportunity of what was a poorly named variable. When you get this in, we can merge this PR.
be7c231
to
d0ccc9b
Compare
@Raffo thanks for the suggestion, I updated the wording |
Co-authored-by: Raffaele Di Fazio <raffo@github.com>
d0ccc9b
to
43f9f56
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Raffo, tjamet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Currently, the minimum delay between 2 kubernetes events handling is
hard-coded to 5s.
This may cause higher synchronization rates and higher DNS provider API
calls when handling an important number of kubernetes events at once.
Give the opportunity to configure this delay so service owners can
define the acceptable thresholds on their side
Contributes to fixing #1293
Checklist