-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid nil pointer deference in extractHeadlessEndpoints #2031
Avoid nil pointer deference in extractHeadlessEndpoints #2031
Conversation
Welcome @allenporter! |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Finished. |
Skip address when TargetRef is nil
77f1d5e
to
a19deeb
Compare
/assign @njuettner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@allenporter thanks for creating a PR 👍🏻 , do you mind adding an additional test for that? I'd like to have some which covers this.
Done. This is my first go change, just to set your expectations -- open to suggestions/improvements of course. |
/kind bug |
/lgtm |
[]string{"foo-0"}, | ||
[]string{"foo-0"}, | ||
[]bool{true, true}, | ||
[]*v1.ObjectReference{nil}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the test for the nil.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: allenporter, Raffo, seanmalloy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Avoid a nil pointer deference in extractHeadlessEndpoints when TargetRef is nil. This was observed for an endpoint created by
kube-prometheus-stack
.Fixes #2029
Checklist