Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

website: render Approved GEPs in numerical order instead of alphabetical #1428

Closed
mikemorris opened this issue Oct 3, 2022 · 1 comment · Fixed by #1438
Closed

website: render Approved GEPs in numerical order instead of alphabetical #1428

mikemorris opened this issue Oct 3, 2022 · 1 comment · Fixed by #1438
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@mikemorris
Copy link
Contributor

mikemorris commented Oct 3, 2022 •
edited
Loading

What would you like to be added:

Approved GEPs should be rendered in reverse chronological order in the website navigation menu (roughly, sorting by PR number instead of date is likely preferable). This may require adding additional metadata to existing GEP files.

Why this is needed:

Currently, Approved GEPs are rendered in alphabetical order, which can be particularly confusing now that we've reached four-digit GEPs.

Screen Shot 2022-10-03 at 5 35 02 PM

/kind documentation
@mikemorris mikemorris added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 3, 2022
@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Oct 3, 2022
@robscott robscott added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Oct 4, 2022
@robscott
Copy link
Member

robscott commented Oct 4, 2022

For reference, this is the line that generates this: https://github.com/kubernetes-sigs/gateway-api/blob/main/.golangci.yml#L42.

@Amila-Rukshan Amila-Rukshan mentioned this issue Oct 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

website: render approved GEPs in chronological order Amila-Rukshan/gateway-api
3 participants
@robscott @mikemorris @k8s-ci-robot