-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
website: render approved GEPs in chronological order #1438
website: render approved GEPs in chronological order #1438
Conversation
|
Welcome @Amila-Rukshan! |
Hi @Amila-Rukshan. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Amila-Rukshan, shaneutt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for finding a way to do this @Amila-Rukshan! I tried experimenting with using the |
@mikemorris I also tried |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
This will order the navigation menu for approved GEPs.
Fix is using the support from the already installed
mkdocs-awesome-pages-plugin
configured as it is given here: https://github.com/lukasgeiter/mkdocs-awesome-pages-plugin#customize-navigation
Now it order the nav items in chronological order:
Which issue(s) this PR fixes:
Fixes #1428
Does this PR introduce a user-facing change?: