Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conformance: GatewaySecretReferenceGrantSpecific is overly restrictive #1536

Closed
howardjohn opened this issue Nov 15, 2022 · 6 comments
Closed

Conformance: GatewaySecretReferenceGrantSpecific is overly restrictive #1536

howardjohn opened this issue Nov 15, 2022 · 6 comments
Assignees
@Xunzhuo
Labels
area/conformance kind/bug Categorizes issue or PR as related to a bug. kind/support Categorizes issue or PR as a support question. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-blocker MUST be completed to complete the milestone
Milestone
v0.7.0

Comments

@howardjohn
Copy link
Contributor

This checks that SupportedKinds is exactly [HTTPRoute]. This is somewhat a requirement of listenersMatch, which requires tests which don't care about the full status (the test has nothing to do with SupportKinds) to specify everything, and do an exact match.

Specifically, this broke us when we implemented GRPCRoute, as we added that as a supported kind

cc @gnossen
@shaneutt shaneutt added the kind/bug Categorizes issue or PR as related to a bug. label Nov 16, 2022
@shaneutt shaneutt added this to the v0.7.0 milestone Nov 16, 2022
@kundan2707
Copy link
Contributor

/kind support

@k8s-ci-robot k8s-ci-robot added the kind/support Categorizes issue or PR as a support question. label Nov 17, 2022
@robscott
Copy link
Member

robscott commented Jan 6, 2023

/area conformance

@shaneutt shaneutt modified the milestones: v0.7.0, v0.6.2 Feb 21, 2023
@shaneutt shaneutt added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Feb 21, 2023
@Xunzhuo
Copy link
Member

Xunzhuo commented Mar 8, 2023

/assign

@shaneutt shaneutt modified the milestones: v0.6.2, v0.7.0 Mar 8, 2023
@shaneutt shaneutt added the release-blocker MUST be completed to complete the milestone label Mar 14, 2023
@shaneutt
Copy link
Member

Marked this as release-blocker as we need to get this fixed before v0.7.0 to avoid breaking people's stuff.

@shaneutt shaneutt added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Mar 14, 2023
@arkodg
Copy link
Contributor

arkodg commented Mar 14, 2023

should be fixed in v0.6.1 with #1692 and #1707

@shaneutt
Copy link
Member

Good call @arkodg, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Xunzhuo Xunzhuo

Labels
area/conformance kind/bug Categorizes issue or PR as related to a bug. kind/support Categorizes issue or PR as a support question. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-blocker MUST be completed to complete the milestone
Projects
No open projects
Gateway API: The Road to GA
Status: Done
Milestone
v0.7.0
Development

No branches or pull requests
7 participants
@robscott @howardjohn @shaneutt @arkodg @k8s-ci-robot @Xunzhuo @kundan2707