Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SupportedKinds check #1692

Merged
merged 4 commits into from
Feb 1, 2023
Merged

Fix SupportedKinds check #1692

merged 4 commits into from
Feb 1, 2023

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Feb 1, 2023

  • Find the expcted SupportedKind element in the actual SupportedKind slice instead of doing an exact match because the actual/implementation populated SupportedKinds field might support more Kind that defined in the test.

Fixes: #1691

Signed-off-by: Arko Dasgupta arko@tetrate.io

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 1, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @arkodg. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@arkodg
Fix SupportedKinds check
4fb1341 
* Find the expcted SupportedKind element in the actual SupportedKind
slice instead of doing an exact match because the actual/implementation
populated SupportedKinds field might support more Kind that defined in
the test.

Fixes: kubernetes-sigs#1691

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 1, 2023
@arkodg
add empty check
26b8e6d 
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
shaneutt
shaneutt reviewed Feb 1, 2023
View reviewed changes
conformance/utils/kubernetes/helpers.go Outdated Show resolved Hide resolved
conformance/utils/kubernetes/helpers.go Show resolved Hide resolved
conformance/utils/kubernetes/helpers.go Outdated Show resolved Hide resolved
@shaneutt shaneutt self-assigned this Feb 1, 2023
@shaneutt shaneutt added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 1, 2023
@arkodg
address comments
a4bdf15 
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg requested review from shaneutt and removed request for robscott and howardjohn February 1, 2023 17:57
@arkodg
use sets.New
15b0c63 
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@shaneutt shaneutt self-requested a review February 1, 2023 22:16
shaneutt
shaneutt approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arkodg, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2023
@k8s-ci-robot k8s-ci-robot merged commit 4ff6208 into kubernetes-sigs:main Feb 1, 2023
@shaneutt shaneutt added this to the v0.6.1 milestone Feb 1, 2023
@arkodg arkodg deleted the fix-supported-kinds branch February 1, 2023 22:59
shaneutt pushed a commit that referenced this pull request Feb 7, 2023
@k8s-ci-robot @shaneutt
Merge pull request #1692 from arkodg/fix-supported-kinds
d5ff596 
Fix SupportedKinds check
@skriss skriss mentioned this pull request Feb 7, 2023
Merged
@sunjayBhatia sunjayBhatia mentioned this pull request Feb 7, 2023
Merged
@shaneutt shaneutt mentioned this pull request Feb 7, 2023
Closed
@arkodg arkodg mentioned this pull request Mar 7, 2023
Closed
9 tasks
@arkodg arkodg mentioned this pull request Mar 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skriss skriss skriss left review comments

@shaneutt shaneutt shaneutt approved these changes

Assignees

@shaneutt shaneutt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.6.1
Development

Successfully merging this pull request may close these issues.

Some conformance tests fail when implementation supports GRPCRoute
4 participants
@arkodg @k8s-ci-robot @skriss @shaneutt