generated from kubernetes/kubernetes-template-project
-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conformance Echo Server Depends on Ingress Controller Conformance Repo #2445
Labels
kind/bug
Categorizes issue or PR as related to a bug.
Comments
SRodi
added a commit
to SRodi/gateway-api
that referenced
this issue
Sep 30, 2023
* add code from Ingress Controller Conformance Repo * update build-and-push.sh to also build this image * create Dockerfile.echoserver * add go.work at root with reference to ./conformance/echoserver * relates to kubernetes-sigs#2445 * discussed in kubernetes-sigs#2254
SRodi
added a commit
to SRodi/gateway-api
that referenced
this issue
Sep 30, 2023
* add code from Ingress Controller Conformance Repo * update build-and-push.sh to also build this image * create Dockerfile.echoserver * add go.work at root with reference to ./conformance/echoserver * add delay support to echoserver * relates to kubernetes-sigs#2445 * discussed in kubernetes-sigs#2254
k8s-ci-robot
pushed a commit
that referenced
this issue
Oct 5, 2023
* add-echo-server-code * add code from Ingress Controller Conformance Repo * update build-and-push.sh to also build this image * create Dockerfile.echoserver * add go.work at root with reference to ./conformance/echoserver * add delay support to echoserver * relates to #2445 * discussed in #2254 * fix go.work * remove deprecated io/ioutil * add-echo-basic * rename to echo-basic (Istio's one can be echo-advanced) * up go.mod go version to 1.20 * fix dockerfile golang version and COPY instruction (paths) * update build-and-push.sh and go.work with new namings * update module name in go.mod * add some basic unit tests * add unit test for tlsStateToAssertions func * add echo-basic to test target in Makefile * fix static check (S1000) * should use a simple channel send/receive instead of select with a single case * add boilerplate to to echo-basic_test.go * add required go.work.sum * required as indirect dependency * see https://stackoverflow.com/a/71613130 * remove go.work files and rename echo-advanced * re-add go.work files as tests are failing on prow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened:
Any time we need to tweak our base image for conformance tests we have to update https://github.com/kubernetes-sigs/ingress-controller-conformance, which is largely frozen in time other than our updates to the base image.
What you expected to happen:
We should likely control the image within Gateway API repo.
I think it would be relatively simple to set this up since we already have a job that builds and pushes images. Our cloudbuild.yaml calls
make release-staging
:gateway-api/Makefile
Lines 156 to 158 in 18506b7
That calls out to
hack/build-and-push.sh
which already builds and pushes multiple images, including our Istio-based echo-server:gateway-api/hack/build-and-push.sh
Lines 68 to 92 in 18506b7
The text was updated successfully, but these errors were encountered: