[conformance] Properly handle lifecycle of an externally passed gRPC client

[gauravkghildiyal]

What would you like to be added:
This issue is for tracking the changes discussed in #3130 (comment)... tl;dr being that MakeRequestAndExpectEventuallyConsistentResponse() should not close an externally passed gRPC client.

Why this is needed:
The same client could be getting used across multiple tests in parallel. Closing the client should be the responsibility of the place where it was created (and not necessarily within the place where the client gets used)

/cc @snehachhabria

[mikemorris]

Makes sense to me - would this change just be moving the defer c.Close() one line up to within the if c == nil conditional and adding a test to confirm it doesn't get closed when a non-nil connection is passed in?

Is there a parallel concern for the HTTP helper too? I'd expect these should have consistent behavior.

/assign

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle rotten
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten