Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GEP-957: Destination Port Matching. #1002

Merged
merged 1 commit into from
Feb 18, 2022

Conversation

cxhiano
Copy link
Contributor

@cxhiano cxhiano commented Jan 26, 2022

What type of PR is this?
/kind feature
/kind api-change

What this PR does / why we need it:

Implement destination port matching proposed in gep-957

Does this PR introduce a user-facing change?:

- Allow routes to select listeners by port number.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 26, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @cxhiano. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 26, 2022
@hbagdi
Copy link
Contributor

hbagdi commented Jan 27, 2022

/ok-to-test
We should add an example (examples/ directory) to make sure we have some CI around it.
We should also add a guide for this. I'm not sure if that has to be part of this PR but I think that should be in the scope of the GEP.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 27, 2022
@cxhiano
Copy link
Contributor Author

cxhiano commented Feb 9, 2022

Example added. PTAL

Agreed that we could have a guide(probably in a separate PR). Should the guide be centered around Route <> Listener attachment or Route <> custom CRD(e.g. Mesh) attachment? I am not sure though.

Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cxhiano! This mostly LGTM, do you mind creating a follow up issue to track adding docs for this feature?

apis/v1alpha2/shared_types.go Outdated Show resolved Hide resolved
@cxhiano
Copy link
Contributor Author

cxhiano commented Feb 15, 2022

I created #1021 for tracking documentation improvement.

@hbagdi
Copy link
Contributor

hbagdi commented Feb 15, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2022
@youngnick
Copy link
Contributor

I think this is looking great, aside from the small note about the experimental status of Port in the stable docs.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2022
@robscott
Copy link
Member

@cxhiano looks like you need to run hack/update-codegen.sh, otherwise LGTM.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cxhiano, howardjohn, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2022
@robscott
Copy link
Member

Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2022
@k8s-ci-robot k8s-ci-robot merged commit d80ef32 into kubernetes-sigs:master Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants