Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor conformance test fixes #1036

Merged
merged 3 commits into from
Mar 9, 2022
Merged

minor conformance test fixes #1036

merged 3 commits into from
Mar 9, 2022

Conversation

skriss
Copy link
Contributor

@skriss skriss commented Mar 9, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:

  • allows Succeeded pods to exist in conformance test namespaces
  • fixes loop variable bug in parallel conformance tests
  • fixes HTTPRoute hostname in the "matching across routes" conformance test

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?:

NONE

@skriss
conformance: fix loop variable/parallel test issues
576150e 
Fixes issues in the conformance tests with
reusing a loop variable across parallel tests.

Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss
conformance: allow Succeeded pods in test namespaces
86c615a 
Relaxes the NamespacesMustBeReady function to also
allow pods to be in the Succeeded phase to allow for
e.g. job-spawned pods.

Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss
conformance: adjust HTTPRoute hostname
df4f1ca 
Updates the hostname of the second HTTPRoute
in the "matching across routes" test to
"example.com" from "*.com".

Signed-off-by: Steve Kriss <krisss@vmware.com>
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 9, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @skriss. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 9, 2022
@robscott
Copy link
Member

robscott commented Mar 9, 2022

Thanks @skriss!

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 9, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, skriss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2022
@k8s-ci-robot k8s-ci-robot merged commit 073ee89 into kubernetes-sigs:master Mar 9, 2022
@skriss skriss mentioned this pull request Jun 3, 2022
Closed
9 tasks
@skriss skriss deleted the conformance-fixes branch June 8, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpeach jpeach Awaiting requested review from jpeach

@thockin thockin Awaiting requested review from thockin

Assignees

@robscott robscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skriss @k8s-ci-robot @robscott