Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conformance: add hostname intersection test #1144

Merged
merged 2 commits into from
Jun 14, 2022
Merged

conformance: add hostname intersection test #1144

merged 2 commits into from
Jun 14, 2022

Conversation

skriss
Copy link
Contributor

@skriss skriss commented May 4, 2022 •
edited
Loading

What type of PR is this?
/area conformance

What this PR does / why we need it:
Adds a conformance test that validates hostname
intersection between HTTPRoutes and Listeners.

Which issue(s) this PR fixes:
Updates #1104

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 4, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @skriss. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 4, 2022
@robscott
Copy link
Member

robscott commented May 6, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 6, 2022
@skriss
conformance: add hostname intersection test
2382f8a 
Adds a conformance test that validates hostname
intersection betwen HTTPRoutes and Listeners.

Updates kubernetes-sigs#1104.

Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss force-pushed the conf-final-hostname-intersection branch from 1ae566f to 2382f8a Compare May 12, 2022 15:14
robscott
robscott reviewed May 17, 2022
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rainest! This mostly looks good to me. I'd like to reach some kind of consensus on #1159 before adding more tests related to it, hopefully we can cover that in our next community meeting.

conformance/tests/httproute-hostname-intersection.go Outdated
Comment on lines 103 to 106
http.ExpectedResponse{
Request: http.ExpectedRequest{Host: "foo.bar.wildcard.io", Path: "/s2"},
StatusCode: 404,
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x-ref #1159

conformance/tests/httproute-hostname-intersection.go Outdated
Comment on lines 158 to 162
http.ExpectedResponse{
Request: http.ExpectedRequest{Host: "too.many.anotherwildcard.io", Path: "/s4"},
StatusCode: 404,
},
http.ExpectedResponse{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x-ref #1159

@rainest
Copy link
Contributor

rainest commented May 17, 2022 •
edited
Loading

@robscott was that intended as a comment on one of my PRs or indeed this one with autocomplete being not helpful? Looks like the latter, doesn't look like this intersects with mine.

@skriss skriss mentioned this pull request Jun 3, 2022
Closed
9 tasks
@skriss
updates for wildcard suffix matching
79c6778 
Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss
Copy link
Contributor Author

skriss commented Jun 6, 2022

Updated based on #1159.

@robscott
Copy link
Member

robscott commented Jun 8, 2022

@rainest sorry for the confusion, not sure what I did but likely an accidental @.

1 similar comment
@robscott
Copy link
Member

robscott commented Jun 8, 2022

@rainest sorry for the confusion, not sure what I did but likely an accidental @.

@robscott
Copy link
Member

robscott commented Jun 8, 2022

Thanks @skriss! This change LGTM and tests appear to be working as expected. Will leave a bit of time for someone else to chime in and add final LGTM.

/approve

1 similar comment
@robscott
Copy link
Member

robscott commented Jun 8, 2022

Thanks @skriss! This change LGTM and tests appear to be working as expected. Will leave a bit of time for someone else to chime in and add final LGTM.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, skriss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, skriss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2022
@skriss
Copy link
Contributor Author

skriss commented Jun 14, 2022

If possible, it'd be nice to get this merged before the v0.5.0 release.

@robscott
Copy link
Member

Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit c44ad73 into kubernetes-sigs:master Jun 14, 2022
@skriss skriss mentioned this pull request Jun 14, 2022
Merged
@skriss skriss deleted the conf-final-hostname-intersection branch July 1, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robscott robscott robscott left review comments

@bowei bowei Awaiting requested review from bowei

@youngnick youngnick Awaiting requested review from youngnick

Assignees

@robscott robscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skriss @k8s-ci-robot @robscott @rainest