recopy the v1beta1 types #1192
Merged
recopy the v1beta1 types #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mehabhalodiya <mehabhalodiya@gmail.com>
Signed-off-by: mehabhalodiya <mehabhalodiya@gmail.com>
Signed-off-by: mehabhalodiya <mehabhalodiya@gmail.com>
k8s-ci-robot
added
kind/feature
Signed-off-by: mehabhalodiya <mehabhalodiya@gmail.com>
Signed-off-by: mehabhalodiya <mehabhalodiya@gmail.com> Rename files to reflect ReferencePolicy -> ReferenceGrant These were missed in kubernetes-sigs#1179 feat: introduce v1beta1 types Signed-off-by: mehabhalodiya <mehabhalodiya@gmail.com> recopy the v1beta1 types Signed-off-by: mehabhalodiya <mehabhalodiya@gmail.com> change package Signed-off-by: mehabhalodiya <mehabhalodiya@gmail.com>
…way-api into v1beta1-types
robscott
added
the
tide/merge-method-squash
|
Thanks @mehabhalodiya! This LGTM, I think there are one or two more recent changes that may have been missed + we need to update CRD generation based on that. I'll make a follow up PR for those things, but I think we should get this in now. /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mehabhalodiya, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mehabhalodiya mehabhalodiya@gmail.com
What type of PR is this?
/kind feature
What this PR does / why we need it:
As suggested by @robscott, this is a follow-up PR on one of our last steps before the v1beta1 (v0.5.0) release.
The key is that we’d need
GatewayClass,Gateway, andHTTPRoutetype definitions inapis/v1beta1in addition to the alpha directories they already exist in.Which issue(s) this PR fixes:
Fixes #1041
Does this PR introduce a user-facing change?: