changed docstring in shared_types.go to account for empty strings being an error

[asim-reza]

Issue
ParentReference.Namespace has unnecessary pointer to string. #1220

What type of PR is this?
/kind documentation

What this PR does / why we need it:
In reference to the Issue mentioned above (#1220) it was decided that setting the value as an empty string for the field namespace is an error, and this is now reflected in its docstring

Which issue(s) this PR fixes:
Fixes #1220

Does this PR introduce a user-facing change?:

NONE

[k8s-ci-robot]

Welcome @asim-reza!

It looks like this is your first PR to kubernetes-sigs/gateway-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @asim-reza. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[markmc]

Thank you for your patch!

Could you also make this change to the v1beta1 docs?

[markmc]

Suggested change

	// Namespace is the namespace of the referent. When unspecified, this refers
	// to the local namespace of the Route. Refer to the Namespace type for valid
	// values.
	// Namespace is the namespace of the referent. When unspecified, this refers
	// to the local namespace of the Route.

I think the "Refer to the Namespace type" bit isn't useful because the docs will include a link to that type. If it was useful, we'd have to say it everywhere for every type.

[asim-reza]

Hey! I think I made the change for both v1alpha2 and v1beta1... Unless I pushed it wrong

[k8s-ci-robot]

@markmc: The label(s) /label ok-to-test cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor

In response to this:

Thank you for your patch!

Could you also make this change to the v1beta1 docs?

/label ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[markmc]

/ok-to-test

[asim-reza]

/retest

[markmc]

Thanks!

/lgtm

[asim-reza]

/test pull-gateway-api-verify

[asim-reza]

@keithmattix
@youngnick

[youngnick]

This LGTM, nice work.

Running make generate and pushing the result should clear up the CI failures.

Once that's done, I'll approve. Thanks for making your first change!

[youngnick]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asim-reza, youngnick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [youngnick]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment