-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull out the duplicate namespace definition to a separate 0-namespace.yaml
file
#1377
Pull out the duplicate namespace definition to a separate 0-namespace.yaml
file
#1377
Conversation
….yaml file. Signed-off-by: Huang Xin <xin1.huang@intel.com>
Welcome @gyohuangxin! |
Hi @gyohuangxin. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks @gyohuangxin! Will leave final LGTM for someone else in case I missed anything with this proposed approach. /ok-to-test |
@robscott Thanks, got it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gyohuangxin, robscott, shaneutt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
release-0.5: Cherry pick #1377 - Pull out the duplicate namespace definition to a separate 0-namespace.yaml file.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR fixes duplicate namespace definition in
config/webhook/certificate_config.yaml
andconfig/webhook/admission_webhook.yaml
. It pulls out the namespace definition to a separate0-namespace.yaml
file.Which issue(s) this PR fixes:
Fixes #1374
Does this PR introduce a user-facing change?: