Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove workaround logics in verify-examples-kind.sh #1415

Conversation

tokers
Copy link
Contributor

@tokers tokers commented Sep 28, 2022

Signed-off-by: Chao Zhang tokers@apache.org

What type of PR is this?

/kind feature
/kind cleanup

What this PR does / why we need it:

Previously, we have some workaround logics in the hack/verify-examples-kind.sh, it modifies the image tag in config/webhook/admission_webhook.yaml, so that the latest commit of admission webhook can be used.

This PR removed the hack logic by using the customization feature in Kustomize, see https://kubernetes.io/docs/tasks/manage-kubernetes-objects/kustomization/#customizing for the details. We create the config/webhook/kustomization.yaml file temporarily (and remove it when cleanup), which replaces the webhook image tag from v0.5.0 (or others in the future) to latest.

Which issue(s) this PR fixes:

Fixes #1366

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Chao Zhang <tokers@apache.org>
Signed-off-by: Chao Zhang <tokers@apache.org>
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 28, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @tokers. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 28, 2022
@robscott
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 30, 2022
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tokers! This is a creative solution.

hack/verify-examples-kind.sh Outdated Show resolved Hide resolved
hack/verify-examples-kind.sh Show resolved Hide resolved
hack/verify-examples-kind.sh Show resolved Hide resolved
Signed-off-by: Chao Zhang <tokers@apache.org>
@robscott
Copy link
Member

robscott commented Oct 4, 2022

Thanks @tokers!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, tokers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2022
@k8s-ci-robot k8s-ci-robot merged commit 1e037bb into kubernetes-sigs:main Oct 4, 2022
@tokers tokers deleted the chore/enhance-verify-examples-kind.sh branch October 6, 2022 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update hack/verify-examples-kind.sh to work better with releases
3 participants