Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarifying ReferenceGrant documentation #1429

Merged
merged 1 commit into from
Oct 3, 2022
Merged

Clarifying ReferenceGrant documentation #1429

merged 1 commit into from
Oct 3, 2022

Conversation

robscott
Copy link
Member

@robscott robscott commented Oct 3, 2022

What type of PR is this?
/kind documentation

What this PR does / why we need it:
In response to some recent sig-auth feedback, this clarifies some parts of the ReferenceGrant API.

Does this PR introduce a user-facing change?:

- Clarification that changes to ReferenceGrants MUST be reconciled

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 3, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 3, 2022
@mikemorris
Copy link
Contributor

mikemorris commented Oct 3, 2022 •
edited
Loading

This had some prior discussion in #1112, and the clarification here seems to resolve the remaining needed clarity for the "unpermitted" case.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 3, 2022
@k8s-ci-robot k8s-ci-robot merged commit 0647412 into kubernetes-sigs:main Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaneutt shaneutt Awaiting requested review from shaneutt

@youngnick youngnick Awaiting requested review from youngnick

Assignees

@mikemorris mikemorris

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robscott @k8s-ci-robot @mikemorris