add ListenerConditionAccepted, update docs from "Detached"

[mikemorris]

What type of PR is this?
/kind cleanup
/kind documentation
/kind api-change
/kind deprecation

What this PR does / why we need it:
Implements the switch from ListenerConditionDetached to a new ListenerConditionAttached, as recommended in GEP-1364.

Which issue(s) this PR fixes:

Fixes #1110, refs #1364

Does this PR introduce a user-facing change?:

Adds `ListenerConditionAccepted` and `ListenerReasonAccepted`
Deprecates `ListenerConditionDetached` and `ListenerReasonAttached`

Now that we've settled on the expected behavior, these expectations should likely be added to relevant conformance tests.

[shaneutt]

Looking good. What are you looking for RE: kubebuilder annotations?

[mikemorris]

@shaneutt I'm curious if something like the following can/should be used more granularly, like for these constants?

gateway-api/apis/v1alpha2/httproute_types.go

Line 29 in 006a257

// +kubebuilder:deprecatedversion:warning="The v1alpha2 version of HTTPRoute has been deprecated and will be removed in a future release of the API. Please upgrade to v1beta1."

gateway-api/config/crd/standard/gateway.networking.k8s.io_httproutes.yaml

Lines 28 to 30 in 006a257

	deprecated: true
	deprecationWarning: The v1alpha2 version of HTTPRoute has been deprecated and
	will be removed in a future release of the API. Please upgrade to v1beta1.

Or alternatively if there's some preferred convention like

gateway-api/apis/v1beta1/zz_generated.register.go

Line 34 in 751ccfc

// Deprecated: use GroupVersion instead.

[shaneutt]

@shaneutt I'm curious if something like the following can/should be used more granularly, like for these constants?

gateway-api/apis/v1alpha2/httproute_types.go

Line 29 in 006a257

// +kubebuilder:deprecatedversion:warning="The v1alpha2 version of HTTPRoute has been deprecated and will be removed in a future release of the API. Please upgrade to v1beta1."

gateway-api/config/crd/standard/gateway.networking.k8s.io_httproutes.yaml

Lines 28 to 30 in 006a257

	deprecated: true
	deprecationWarning: The v1alpha2 version of HTTPRoute has been deprecated and
	will be removed in a future release of the API. Please upgrade to v1beta1.

Or alternatively if there's some preferred convention like

gateway-api/apis/v1beta1/zz_generated.register.go

Line 34 in 751ccfc

// Deprecated: use GroupVersion instead.

Ah, now I see what you're getting at. I am only aware of the kubebuilder:deprecatedversion tag as per the kubebuilder CRD generation documentation, which does not apply here because it marks the entire version as deprecated. I am not aware of any way to call a specific field deprecated. I think we can just use the godoc you've already provided explaining that it's deprecated for now, maybe we can open/find an upstream issue to add something that automates this for us in kubebuilder later.

[mikemorris]

Removed TODOs and switched deprecation warnings from passive to active voice, think this should be ready to go now.

[robscott]

Thanks @mikemorris!

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikemorris, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [robscott]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[howardjohn]

The docs here (L330) are wrong now, the polarity should be inverted