-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Programmed" Gateway condition, move "Ready" to extended conformance #1499
Conversation
Hi @LCaparelli. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @LCaparelli! This mostly LGTM, would appreciate a review from @youngnick as well though.
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API changes look great, but I think there's quite a bit more work to do to update all the conformance tests.
@LCaparelli, did you want to round out the conformance test updates in this PR, or should one of us do it in a follow-up?
@youngnick, @robscott thanks for the review!
Oh, I kinda just searched for usages of
Am I missing other places where this is checked but is not using the consts? Or did you mean something else? If you mean other tests that were not initially in the issue's scope I'm happy to help and can either do it here or in a follow-up. |
Thanks for the update @LCaparelli! Hmm, I just went and checked, and I was thinking of this function call: gateway-api/conformance/utils/kubernetes/helpers.go Lines 135 to 139 in 9568c67
But it turns out that's actually already checking for Additionally, it looks like this function needs an update: gateway-api/conformance/utils/kubernetes/helpers.go Lines 92 to 95 in 9568c67
It's looking for the Gateway to be Ready , but we're not using the constant, just the string Ready . May be worth a case-sensitive search for Ready as well to find any other uses in the conformance/ directory.
Sorry to be picky, but I want to make sure we squash all the |
Yup, no worries at all @youngnick! Thanks for the additional pointers, I'll take a more thorough look |
Signed-off-by: Lucas Caparelli <lucas.caparelli@gympass.com>
Signed-off-by: Lucas Caparelli <lucas.caparelli@gympass.com>
Signed-off-by: Lucas Caparelli <lucas.caparelli@gympass.com>
Signed-off-by: Lucas Caparelli <lucas.caparelli@gympass.com>
@youngnick @robscott I think I got it all covered this time, please take a look at the last 4 commits when you can. Thanks again for the guidance! |
I can't see anything else this time, nice work @LCaparelli. I'll approve and let @robscott or @shaneutt do the final LGTM. This is the one that will break v0.5.1 conformance though, i think. /approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, couple small language nits.
Signed-off-by: Lucas Caparelli <lucas.caparelli@gympass.com>
Thanks @shaneutt, fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LCaparelli, shaneutt, youngnick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
/kind api-change
What this PR does / why we need it: Make necessary changes to Gateway and Listener conditions in order to implement GEP-1364.
Which issue(s) this PR fixes:
Fixes #1454
Does this PR introduce a user-facing change?: