Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conformance: Update HTTPRouteInvalidParentRefNotMatchingListenerPort #1591

Merged
merged 1 commit into from
Dec 12, 2022
Merged

conformance: Update HTTPRouteInvalidParentRefNotMatchingListenerPort #1591

merged 1 commit into from
Dec 12, 2022

Conversation

sayboras
Copy link
Contributor

@sayboras sayboras commented Dec 9, 2022 •
edited
Loading

Description

The manifest for not matching listener port is rejected by admission webhook due to missing port for Service reference. While the test is to verify some other behavior (i.e. parent gateway port is not matching), it's better to have valid resource to avoid any confusion or any implementation expectation, not to mention to be consistent with other conformance tests (e.g. invalid-cross-namespace-parent-ref).

This commit also updates gateway name used in verification step to be consistent of the gateway used in HTTPRoute resource.

Signed-off-by: Tam Mach sayboras@yahoo.com

What type of PR is this?

/kind failing-test

conformance: Update HTTPRouteInvalidParentRefNotMatchingListenerPort

Testing

Testing was done by running the whole conformance suite with below command with Cilium implementation:

  • this new test is run successfully, and
  • there is no interference with existing tests.

image

Running conformance tests with all features 
$ go test -v ./operator/pkg/gateway-api --gateway-class cilium --supported-features ReferenceGrant,TLSRoute,HTTPRouteQueryParamMatching,HTTPRouteMethodMatching,HTTPResponseHeaderModification,RouteDestinationPortMatching --debug -test.run "TestConformance"
--- PASS: TestConformance (42.82s)
    --- PASS: TestConformance/GatewayInvalidRouteKind (1.08s)
        --- PASS: TestConformance/GatewayInvalidRouteKind/Gateway_listener_should_have_a_false_ResolvedRefs_condition_with_reason_InvalidRouteKinds_and_no_supportedKinds (1.01s)
        --- PASS: TestConformance/GatewayInvalidRouteKind/Gateway_listener_should_have_a_false_ResolvedRefs_condition_with_reason_InvalidRouteKinds_and_HTTPRoute_must_be_put_in_the_supportedKinds (0.00s)
    --- PASS: TestConformance/GatewayInvalidTLSConfiguration (0.15s)
        --- PASS: TestConformance/GatewayInvalidTLSConfiguration/Nonexistent_secret_referenced_as_CertificateRef_in_a_Gateway_listener (0.01s)
        --- PASS: TestConformance/GatewayInvalidTLSConfiguration/Malformed_secret_referenced_as_CertificateRef_in_a_Gateway_listener (1.01s)
        --- PASS: TestConformance/GatewayInvalidTLSConfiguration/Unsupported_kind_resource_referenced_as_CertificateRef_in_a_Gateway_listener (1.01s)
        --- PASS: TestConformance/GatewayInvalidTLSConfiguration/Unsupported_group_resource_referenced_as_CertificateRef_in_a_Gateway_listener (1.01s)
    --- PASS: TestConformance/GatewaySecretInvalidReferenceGrant (0.21s)
        --- PASS: TestConformance/GatewaySecretInvalidReferenceGrant/Gateway_listener_should_have_a_false_ResolvedRefs_condition_with_reason_RefNotPermitted (0.01s)
    --- PASS: TestConformance/GatewaySecretMissingReferenceGrant (1.04s)
        --- PASS: TestConformance/GatewaySecretMissingReferenceGrant/Gateway_listener_should_have_a_false_ResolvedRefs_condition_with_reason_RefNotPermitted (1.02s)
    --- PASS: TestConformance/GatewaySecretReferenceGrantAllInNamespace (1.08s)
        --- PASS: TestConformance/GatewaySecretReferenceGrantAllInNamespace/Gateway_listener_should_have_a_true_ResolvedRefs_condition_and_a_true_Programmed_condition (1.01s)
    --- PASS: TestConformance/GatewaySecretReferenceGrantSpecific (1.07s)
        --- PASS: TestConformance/GatewaySecretReferenceGrantSpecific/Gateway_listener_should_have_a_true_ResolvedRefs_condition_and_a_true_Programmed_condition (1.01s)
    --- PASS: TestConformance/HTTPRouteCrossNamespace (1.04s)
        --- PASS: TestConformance/HTTPRouteCrossNamespace/Simple_HTTP_request_should_reach_web-backend (1.01s)
    --- PASS: TestConformance/HTTPRouteDisallowedKind (1.09s)
        --- PASS: TestConformance/HTTPRouteDisallowedKind/Route_should_not_have_Parents_set_in_status (0.00s)
        --- PASS: TestConformance/HTTPRouteDisallowedKind/Gateway_should_have_0_Routes_attached (0.00s)
    --- PASS: TestConformance/HTTPExactPathMatching (0.04s)
        --- PASS: TestConformance/HTTPExactPathMatching/3_request_to_'/one/example'_should_receive_a_404 (1.00s)
        --- PASS: TestConformance/HTTPExactPathMatching/4_request_to_'/two/'_should_receive_a_404 (1.00s)
        --- PASS: TestConformance/HTTPExactPathMatching/2_request_to_'/'_should_receive_a_404 (1.00s)
        --- PASS: TestConformance/HTTPExactPathMatching/0_request_to_'/one'_should_go_to_infra-backend-v1 (1.01s)
        --- PASS: TestConformance/HTTPExactPathMatching/1_request_to_'/two'_should_go_to_infra-backend-v2 (1.01s)
    --- PASS: TestConformance/HTTPRouteHeaderMatching (0.04s)
        --- PASS: TestConformance/HTTPRouteHeaderMatching/5_request_to_'/'_with_headers_should_receive_a_404 (0.00s)
        --- PASS: TestConformance/HTTPRouteHeaderMatching/4_request_to_'/'_with_headers_should_receive_a_404 (0.00s)
        --- PASS: TestConformance/HTTPRouteHeaderMatching/10_request_to_'/'_with_headers_should_receive_a_404 (0.00s)
        --- PASS: TestConformance/HTTPRouteHeaderMatching/0_request_to_'/'_with_headers_should_go_to_infra-backend-v1 (1.00s)
        --- PASS: TestConformance/HTTPRouteHeaderMatching/1_request_to_'/'_with_headers_should_go_to_infra-backend-v2 (1.00s)
        --- PASS: TestConformance/HTTPRouteHeaderMatching/9_request_to_'/'_with_headers_should_go_to_infra-backend-v2 (1.00s)
        --- PASS: TestConformance/HTTPRouteHeaderMatching/3_request_to_'/'_with_headers_should_go_to_infra-backend-v2 (1.00s)
        --- PASS: TestConformance/HTTPRouteHeaderMatching/2_request_to_'/'_with_headers_should_go_to_infra-backend-v1 (1.00s)
        --- PASS: TestConformance/HTTPRouteHeaderMatching/7_request_to_'/'_with_headers_should_go_to_infra-backend-v1 (1.00s)
        --- PASS: TestConformance/HTTPRouteHeaderMatching/6_request_to_'/'_with_headers_should_go_to_infra-backend-v1 (1.01s)
        --- PASS: TestConformance/HTTPRouteHeaderMatching/8_request_to_'/'_with_headers_should_go_to_infra-backend-v2 (1.00s)
    --- PASS: TestConformance/HTTPRouteHostnameIntersection (5.21s)
        --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames (5.02s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/11_request_to_'foo.wildcard.io/non-matching-prefix'_should_receive_a_404 (0.00s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/1_request_to_'non.matching.com/s1'_should_receive_a_404 (0.00s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/3_request_to_'foo.wildcard.io/s1'_should_receive_a_404 (0.00s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/13_request_to_'non.matching.com/s3'_should_receive_a_404 (0.00s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/22_request_to_'very.specific.com/s4'_should_receive_a_404 (0.00s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/23_request_to_'foo.anotherwildcard.io/non-matching-prefix'_should_receive_a_404 (0.00s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/14_request_to_'foo.specific.com/s3'_should_receive_a_404 (0.00s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/16_request_to_'very.specific.com/non-matching-prefix'_should_receive_a_404 (0.00s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/8_request_to_'non.matching.com/s2'_should_receive_a_404 (0.00s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/20_request_to_'anotherwildcard.io/s4'_should_receive_a_404 (0.00s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/21_request_to_'foo.wildcard.io/s4'_should_receive_a_404 (0.00s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/10_request_to_'very.specific.com/s2'_should_receive_a_404 (0.00s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/4_request_to_'very.specific.com/non-matching-prefix'_should_receive_a_404 (0.00s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/9_request_to_'wildcard.io/s2'_should_receive_a_404 (0.00s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/2_request_to_'foo.nonmatchingwildcard.io/s1'_should_receive_a_404 (0.00s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/15_request_to_'foo.wildcard.io/s3'_should_receive_a_404 (0.00s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/19_request_to_'foo.bar.anotherwildcard.io/s4'_should_go_to_infra-backend-v1 (0.01s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/18_request_to_'bar.anotherwildcard.io/s4'_should_go_to_infra-backend-v1 (0.01s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/17_request_to_'foo.anotherwildcard.io/s4'_should_go_to_infra-backend-v1 (0.00s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/0_request_to_'very.specific.com/s1'_should_go_to_infra-backend-v1 (0.01s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/6_request_to_'bar.wildcard.io/s2'_should_go_to_infra-backend-v2 (0.01s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/5_request_to_'foo.wildcard.io/s2'_should_go_to_infra-backend-v2 (0.01s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/7_request_to_'foo.bar.wildcard.io/s2'_should_go_to_infra-backend-v2 (0.00s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_intersect_with_listener_hostnames/12_request_to_'very.specific.com/s3'_should_go_to_infra-backend-v3 (0.01s)
        --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_not_intersect_with_listener_hostnames (0.00s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_not_intersect_with_listener_hostnames/0_request_to_'specific.but.wrong.com/s5'_should_receive_a_404 (0.00s)
            --- PASS: TestConformance/HTTPRouteHostnameIntersection/HTTPRoutes_that_do_not_intersect_with_listener_hostnames/1_request_to_'wildcard.io/s5'_should_receive_a_404 (0.00s)
    --- PASS: TestConformance/HTTPRouteInvalidNonExistentBackendRef (1.07s)
        --- PASS: TestConformance/HTTPRouteInvalidNonExistentBackendRef/HTTPRoute_with_only_a_nonexistent_BackendRef_has_a_ResolvedRefs_Condition_with_status_False_and_Reason_BackendNotFound (0.03s)
        --- PASS: TestConformance/HTTPRouteInvalidNonExistentBackendRef/HTTP_Request_to_invalid_nonexistent_backend_receive_a_500 (1.00s)
    --- PASS: TestConformance/HTTPRouteInvalidBackendRefUnknownKind (0.05s)
        --- PASS: TestConformance/HTTPRouteInvalidBackendRefUnknownKind/HTTPRoute_with_Invalid_Kind_has_a_ResolvedRefs_Condition_with_status_False_and_Reason_InvalidKind (0.00s)
        --- PASS: TestConformance/HTTPRouteInvalidBackendRefUnknownKind/HTTP_Request_to_invalid_backend_with_invalid_Kind_receives_a_500 (0.00s)
    --- PASS: TestConformance/HTTPRouteInvalidCrossNamespaceBackendRef (0.04s)
        --- PASS: TestConformance/HTTPRouteInvalidCrossNamespaceBackendRef/HTTPRoute_with_a_cross-namespace_BackendRef_and_no_ReferenceGrant_has_a_ResolvedRefs_Condition_with_status_False_and_Reason_RefNotPermitted (0.00s)
        --- PASS: TestConformance/HTTPRouteInvalidCrossNamespaceBackendRef/HTTP_Request_to_invalid_cross-namespace_backend_must_receive_a_500 (0.00s)
    --- PASS: TestConformance/HTTPRouteInvalidCrossNamespaceParentRef (0.03s)
        --- PASS: TestConformance/HTTPRouteInvalidCrossNamespaceParentRef/Route_should_not_have_Parents_set_in_status (0.01s)
        --- PASS: TestConformance/HTTPRouteInvalidCrossNamespaceParentRef/Gateway_should_have_0_Routes_attached (0.01s)
    --- PASS: TestConformance/HTTPRouteInvalidParentRefNotMatchingListenerPort (1.03s)
        --- PASS: TestConformance/HTTPRouteInvalidParentRefNotMatchingListenerPort/HTTPRoute_with_no_matching_port_in_ParentRef_has_an_Accepted_Condition_with_status_False_and_Reason_NoMatchingParent (1.01s)
        --- PASS: TestConformance/HTTPRouteInvalidParentRefNotMatchingListenerPort/Route_should_not_have_Parents_accepted_in_status (0.00s)
        --- PASS: TestConformance/HTTPRouteInvalidParentRefNotMatchingListenerPort/Gateway_should_have_0_Routes_attached (0.00s)
    --- PASS: TestConformance/HTTPRouteListenerHostnameMatching (3.15s)
        --- PASS: TestConformance/HTTPRouteListenerHostnameMatching/6_request_to_'foo.com/'_should_receive_a_404 (0.00s)
        --- PASS: TestConformance/HTTPRouteListenerHostnameMatching/7_request_to_'no.matching.host/'_should_receive_a_404 (0.00s)
        --- PASS: TestConformance/HTTPRouteListenerHostnameMatching/2_request_to_'baz.bar.com/'_should_go_to_infra-backend-v3 (0.00s)
        --- PASS: TestConformance/HTTPRouteListenerHostnameMatching/5_request_to_'multiple.prefixes.foo.com/'_should_go_to_infra-backend-v3 (0.00s)
        --- PASS: TestConformance/HTTPRouteListenerHostnameMatching/3_request_to_'boo.bar.com/'_should_go_to_infra-backend-v3 (0.00s)
        --- PASS: TestConformance/HTTPRouteListenerHostnameMatching/1_request_to_'foo.bar.com/'_should_go_to_infra-backend-v2 (0.00s)
        --- PASS: TestConformance/HTTPRouteListenerHostnameMatching/4_request_to_'multiple.prefixes.bar.com/'_should_go_to_infra-backend-v3 (0.00s)
        --- PASS: TestConformance/HTTPRouteListenerHostnameMatching/0_request_to_'bar.com/'_should_go_to_infra-backend-v1 (0.00s)
    --- PASS: TestConformance/HTTPRouteMatchingAcrossRoutes (0.08s)
        --- PASS: TestConformance/HTTPRouteMatchingAcrossRoutes/2_request_to_'example.net/example'_should_go_to_infra-backend-v1 (0.00s)
        --- PASS: TestConformance/HTTPRouteMatchingAcrossRoutes/0_request_to_'example.com/'_should_go_to_infra-backend-v1 (0.00s)
        --- PASS: TestConformance/HTTPRouteMatchingAcrossRoutes/1_request_to_'example.com/example'_should_go_to_infra-backend-v1 (0.00s)
        --- PASS: TestConformance/HTTPRouteMatchingAcrossRoutes/5_request_to_'example.net/v2'_should_go_to_infra-backend-v1 (0.00s)
        --- PASS: TestConformance/HTTPRouteMatchingAcrossRoutes/3_request_to_'example.com/example'_with_headers_should_go_to_infra-backend-v1 (0.00s)
        --- PASS: TestConformance/HTTPRouteMatchingAcrossRoutes/7_request_to_'example.com/'_with_headers_should_go_to_infra-backend-v2 (1.00s)
        --- PASS: TestConformance/HTTPRouteMatchingAcrossRoutes/4_request_to_'example.com/v2'_should_go_to_infra-backend-v2 (1.00s)
        --- PASS: TestConformance/HTTPRouteMatchingAcrossRoutes/6_request_to_'example.com/v2/example'_should_go_to_infra-backend-v2 (1.01s)
    --- PASS: TestConformance/HTTPRouteMatching (0.03s)
        --- PASS: TestConformance/HTTPRouteMatching/0_request_to_'/'_should_go_to_infra-backend-v1 (1.00s)
        --- PASS: TestConformance/HTTPRouteMatching/2_request_to_'/'_with_headers_should_go_to_infra-backend-v1 (1.00s)
        --- PASS: TestConformance/HTTPRouteMatching/1_request_to_'/example'_should_go_to_infra-backend-v1 (1.00s)
        --- PASS: TestConformance/HTTPRouteMatching/4_request_to_'/v2/example'_should_go_to_infra-backend-v2 (1.00s)
        --- PASS: TestConformance/HTTPRouteMatching/5_request_to_'/'_with_headers_should_go_to_infra-backend-v2 (1.01s)
        --- PASS: TestConformance/HTTPRouteMatching/3_request_to_'/v2'_should_go_to_infra-backend-v2 (1.01s)
    --- PASS: TestConformance/HTTPRouteMethodMatching (0.03s)
        --- PASS: TestConformance/HTTPRouteMethodMatching/2_request_to_'/'_should_receive_a_404 (1.00s)
        --- PASS: TestConformance/HTTPRouteMethodMatching/0_request_to_'/'_should_go_to_infra-backend-v1 (1.00s)
        --- PASS: TestConformance/HTTPRouteMethodMatching/1_request_to_'/'_should_go_to_infra-backend-v2 (1.00s)
    --- PASS: TestConformance/HTTPRoutePartiallyInvalidViaInvalidReferenceGrant (1.06s)
        --- PASS: TestConformance/HTTPRoutePartiallyInvalidViaInvalidReferenceGrant/HTTPRoute_with_BackendRef_in_another_namespace_and_no_ReferenceGrant_covering_the_Service_has_a_ResolvedRefs_Condition_with_status_False_and_Reason_RefNotPermitted (0.00s)
        --- PASS: TestConformance/HTTPRoutePartiallyInvalidViaInvalidReferenceGrant/HTTP_Request_to_invalid_backend_with_missing_referenceGrant_should_receive_a_500 (1.00s)
        --- PASS: TestConformance/HTTPRoutePartiallyInvalidViaInvalidReferenceGrant/HTTP_Request_to_valid_sibling_backend_should_succeed (0.00s)
    --- PASS: TestConformance/HTTPRouteQueryParamMatching (0.03s)
        --- PASS: TestConformance/HTTPRouteQueryParamMatching/7_request_to_'/?animal=dog'_should_receive_a_404 (1.00s)
        --- PASS: TestConformance/HTTPRouteQueryParamMatching/6_request_to_'/?color=blue'_should_receive_a_404 (1.00s)
        --- PASS: TestConformance/HTTPRouteQueryParamMatching/9_request_to_'/'_should_receive_a_404 (1.00s)
        --- PASS: TestConformance/HTTPRouteQueryParamMatching/8_request_to_'/?animal=whaledolphin'_should_receive_a_404 (1.00s)
        --- PASS: TestConformance/HTTPRouteQueryParamMatching/1_request_to_'/?animal=dolphin'_should_go_to_infra-backend-v2 (1.00s)
        --- PASS: TestConformance/HTTPRouteQueryParamMatching/3_request_to_'/?ANIMAL=Whale'_should_go_to_infra-backend-v3 (1.01s)
        --- PASS: TestConformance/HTTPRouteQueryParamMatching/4_request_to_'/?animal=whale&otherparam=irrelevant'_should_go_to_infra-backend-v1 (1.01s)
        --- PASS: TestConformance/HTTPRouteQueryParamMatching/2_request_to_'/?animal=dolphin&color=blue'_should_go_to_infra-backend-v3 (1.01s)
        --- PASS: TestConformance/HTTPRouteQueryParamMatching/5_request_to_'/?animal=dolphin&color=yellow'_should_go_to_infra-backend-v2 (1.01s)
        --- PASS: TestConformance/HTTPRouteQueryParamMatching/0_request_to_'/?animal=whale'_should_go_to_infra-backend-v1 (1.01s)
    --- PASS: TestConformance/HTTPRouteReferenceGrant (1.09s)
        --- PASS: TestConformance/HTTPRouteReferenceGrant/Simple_HTTP_request_should_reach_web-backend (1.00s)
    --- PASS: TestConformance/HTTPRouteRequestHeaderModifier (0.04s)
        --- PASS: TestConformance/HTTPRouteRequestHeaderModifier/0_request_to_'/set'_with_headers_should_go_to_infra-backend-v1 (1.00s)
        --- PASS: TestConformance/HTTPRouteRequestHeaderModifier/2_request_to_'/add'_with_headers_should_go_to_infra-backend-v1 (1.00s)
        --- PASS: TestConformance/HTTPRouteRequestHeaderModifier/4_request_to_'/remove'_with_headers_should_go_to_infra-backend-v1 (1.00s)
        --- PASS: TestConformance/HTTPRouteRequestHeaderModifier/3_request_to_'/add'_with_headers_should_go_to_infra-backend-v1 (1.00s)
        --- PASS: TestConformance/HTTPRouteRequestHeaderModifier/5_request_to_'/multiple'_with_headers_should_go_to_infra-backend-v1 (1.01s)
        --- PASS: TestConformance/HTTPRouteRequestHeaderModifier/1_request_to_'/set'_with_headers_should_go_to_infra-backend-v1 (1.01s)
        --- PASS: TestConformance/HTTPRouteRequestHeaderModifier/6_request_to_'/case-insensitivity'_with_headers_should_go_to_infra-backend-v1 (1.01s)
    --- PASS: TestConformance/HTTPRouteResponseHeaderModifier (0.04s)
        --- PASS: TestConformance/HTTPRouteResponseHeaderModifier/0_request_to_'/set'_should_go_to_infra-backend-v1 (1.00s)
        --- PASS: TestConformance/HTTPRouteResponseHeaderModifier/2_request_to_'/add'_should_go_to_infra-backend-v1 (1.00s)
        --- PASS: TestConformance/HTTPRouteResponseHeaderModifier/1_request_to_'/set'_should_go_to_infra-backend-v1 (1.00s)
        --- PASS: TestConformance/HTTPRouteResponseHeaderModifier/3_request_to_'/add'_should_go_to_infra-backend-v1 (1.00s)
        --- PASS: TestConformance/HTTPRouteResponseHeaderModifier/4_request_to_'/remove'_should_go_to_infra-backend-v1 (1.00s)
        --- PASS: TestConformance/HTTPRouteResponseHeaderModifier/6_request_to_'/case-insensitivity'_should_go_to_infra-backend-v1 (1.00s)
        --- PASS: TestConformance/HTTPRouteResponseHeaderModifier/5_request_to_'/multiple'_should_go_to_infra-backend-v1 (1.01s)
    --- PASS: TestConformance/HTTPRouteSimpleSameNamespace (1.04s)
        --- PASS: TestConformance/HTTPRouteSimpleSameNamespace/Simple_HTTP_request_should_reach_infra-backend (1.00s)
PASS
ok      github.com/cilium/cilium/operator/pkg/gateway-api       42.851s

@sayboras
conformance: Update HTTPRouteInvalidParentRefNotMatchingListenerPort
b6e7c1d 
The manifest for not matching listener port is rejected by admission
webhook due to missing port for Service reference. While the test is to
verify some other behavior (i.e. parent gateway port is not matching),
it's better to have valid resource to avoid any confusion or any
implementation expectation, not to mention to be consistent with other
conformance tests (e.g. invalid-cross-namespace-parent-ref).

This commit also updates gateway name used in verification step to be
consistent of the gateway used in HTTPRoute resource.

Signed-off-by: Tam Mach <sayboras@yahoo.com>
@k8s-ci-robot k8s-ci-robot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 9, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @sayboras!

It looks like this is your first PR to kubernetes-sigs/gateway-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 9, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @sayboras. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mlavacca
Copy link
Member

mlavacca commented Dec 9, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 9, 2022
mlavacca
mlavacca approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@mlavacca mlavacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @sayboras!

@sunjayBhatia sunjayBhatia mentioned this pull request Dec 9, 2022
Merged
@robscott
Copy link
Member

Thanks @sayboras!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mlavacca, robscott, sayboras

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit 62a67ae into kubernetes-sigs:main Dec 12, 2022
@sayboras sayboras deleted the tam/add-port-conformance-non-matching-route-port branch December 12, 2022 09:43
sayboras added a commit to sayboras/cilium that referenced this pull request Feb 22, 2023
@sayboras
gateway-api: Add support for RouteDestinationPortMatching
9e21c71 
This commit is to make sure that we have the support RouteDestinationPortMatching
feature. The conformance test is enabled accordingly.

Relates: kubernetes-sigs/gateway-api#1591
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit to cilium/cilium that referenced this pull request Feb 23, 2023
@sayboras
gateway-api: Add support for RouteDestinationPortMatching
d6d04c8 
This commit is to make sure that we have the support RouteDestinationPortMatching
feature. The conformance test is enabled accordingly.

Relates: kubernetes-sigs/gateway-api#1591
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@shaneutt shaneutt added this to the v0.7.0 milestone Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlavacca mlavacca mlavacca approved these changes

@mikemorris mikemorris Awaiting requested review from mikemorris

@robscott robscott Awaiting requested review from robscott

Assignees

@robscott robscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
No open projects
Gateway API: The Road to GA
Status: Done
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.
5 participants
@sayboras @k8s-ci-robot @mlavacca @robscott @shaneutt