Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conformance: add attachedRoutes to conformance tests #1624

Merged
merged 3 commits into from
Mar 8, 2023

Conversation

ChaningHwang
Copy link
Contributor

@ChaningHwang ChaningHwang commented Dec 29, 2022

What type of PR is this?
/kind feature
/area conformance

What this PR does / why we need it:
Add attachedRoutes to conformance tests.

Which issue(s) this PR fixes:
Fixes #1543

Does this PR introduce a user-facing change?:
NONE

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 29, 2022
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 29, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @ChaningHwang. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 29, 2022
@robscott
Copy link
Member

Thanks @ChaningHwang!

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 29, 2022
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ChaningHwang! This looks like a good start. Although this doesn't have to block merging this PR, I'd like to have this kind of logic in place across more tests before marking the linked issue as fixed.

conformance/tests/gateway-invalid-tls-certificateref.go Outdated Show resolved Hide resolved
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the time I'm reading this, we're only testing for conditions where AttachedRoutes is expected to be 0, but to cover AttachedRoutes in conformance we should in fact include some tests where it would be 1 and more.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 23, 2023
Copy link
Contributor

@frankbu frankbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't address the question of whether or not the attachedRoutes count should include routes that are attached to invalid not ready Gateways, but maybe the spec isn't going to mandate that one way or another?

Otherwise LGTM

@shaneutt shaneutt self-requested a review March 8, 2023 18:52
@shaneutt shaneutt added this to the v0.7.0 milestone Mar 8, 2023
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the positive cases, and thanks for your contribution! Targeting this for v0.7.0.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChaningHwang, frankbu, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2023
@k8s-ci-robot k8s-ci-robot merged commit 49b4d96 into kubernetes-sigs:main Mar 8, 2023
@shaneutt shaneutt modified the milestones: v0.7.0, v0.6.2 Mar 14, 2023
shaneutt pushed a commit to shaneutt/gateway-api that referenced this pull request Mar 14, 2023
…Routes

conformance: add attachedRoutes to conformance tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

conformance: Update conformance tests to check for correct attachedRoutes value
6 participants