Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove invalid redirect examples #1787

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented Mar 8, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

Remove invalid redirect examples.

Which issue(s) this PR fixes:

Part of: #1779

Does this PR introduce a user-facing change?:


Signed-off-by: bitliu <bitliu@tencent.com>
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 8, 2023
@shaneutt shaneutt added this to the v0.6.2 milestone Mar 8, 2023
@robscott
Copy link
Member

robscott commented Mar 8, 2023

Thanks @Xunzhuo!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, Xunzhuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2023
@k8s-ci-robot k8s-ci-robot merged commit 40a86dc into kubernetes-sigs:main Mar 8, 2023
shaneutt pushed a commit to shaneutt/gateway-api that referenced this pull request Mar 14, 2023
…mples

fix: remove invalid redirect examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

4 participants