Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix grammar in implementation guidelines #1865

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Fix grammar in implementation guidelines #1865

merged 1 commit into from
Mar 22, 2023

Conversation

matteoolivi
Copy link
Contributor

Fix grammar in ReferenceGrant implementation guidelines. Before this PR a sentence is truncated prematurely with a period, and the two chunks of the intended sentence make no sense in isolation. The PR rejoins the two chunks by replacing the period with a comma.

What type of PR is this?

/kind documentation

What this PR does / why we need it:
Fixes a grammar mistake in the documentation.

Does this PR introduce a user-facing change?:

Fix grammar mistake in ReferenceGrant implementation guidelines.

@matteoolivi
Fix grammar in implementation guidelines
874c6f3 
Fix grammar in ReferenceGrant implementation guidelines. Before
this commit a sentence is truncated prematurely with a period,
and the two chunks of the intended sentence make no sense in
isolation. The commit rejoins the two chunks by replacing the
period with a comma.
@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 22, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @matteoolivi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 22, 2023
shaneutt
shaneutt approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matteoolivi, shaneutt, sunjayBhatia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2023
@shaneutt shaneutt added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit 653565d into kubernetes-sigs:main Mar 22, 2023
@matteoolivi matteoolivi deleted the fix-grammar-in-referencegrant-implementation-guideline branch March 23, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaneutt shaneutt shaneutt approved these changes

@sunjayBhatia sunjayBhatia sunjayBhatia approved these changes

@keithmattix keithmattix Awaiting requested review from keithmattix

Assignees

@shaneutt shaneutt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matteoolivi @k8s-ci-robot @shaneutt @sunjayBhatia