Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarifying Port Redirect Behavior #1908

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Clarifying Port Redirect Behavior #1908

merged 1 commit into from
Apr 5, 2023

Conversation

robscott
Copy link
Member

@robscott robscott commented Apr 4, 2023

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This is a follow up to address some of the limitations of the current spec discovered in #1880. Specifically this adjust the spec to say that port shouldn't be added in these cases, not that it needs to be unset/removed.

Does this PR introduce a user-facing change?:

Clarification that port redirects should not add port number to Location header for HTTP and HTTPS requests on 80 and 443.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 4, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 4, 2023
@robscott
Copy link
Member Author

robscott commented Apr 4, 2023

/cc @arkodg @howardjohn @gauravkghildiyal @michaelbeaumont @pleshakov @youngnick

/hold for consensus

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 4, 2023
@k8s-ci-robot
Copy link
Contributor

@robscott: GitHub didn't allow me to request PR reviews from the following users: gauravkghildiyal, pleshakov.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @arkodg @howardjohn @gauravkghildiyal @michaelbeaumont @pleshakov @youngnick

/hold for consensus

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

arkodg
arkodg approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@youngnick
Copy link
Contributor

/lgtm

/hold

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2023
@howardjohn
Copy link
Contributor

/hold

have a quick question

kflynn
kflynn approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@kflynn kflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from here, FWIW!

pleshakov
pleshakov approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@robscott robscott mentioned this pull request Apr 4, 2023
Closed
@robscott
Copy link
Member Author

robscott commented Apr 4, 2023

@howardjohn Based on chat I think I captured your question in #1909. I think that's something that's probably best covered by a follow up, but will leave this PR open until tomorrow in case someone wants to include the resolution to that issue here as well.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arkodg, kflynn, michaelbeaumont, pleshakov, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@howardjohn
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2023
@k8s-ci-robot k8s-ci-robot merged commit c53b790 into kubernetes-sigs:main Apr 5, 2023
@shaneutt shaneutt added this to the v0.7.0 milestone Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kflynn kflynn kflynn approved these changes

@pleshakov pleshakov pleshakov approved these changes

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

@arkodg arkodg arkodg approved these changes

@shaneutt shaneutt Awaiting requested review from shaneutt

@youngnick youngnick Awaiting requested review from youngnick

@howardjohn howardjohn Awaiting requested review from howardjohn

Assignees

@youngnick youngnick

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
No open projects
Gateway API: The Road to GA
Status: Done
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.
9 participants
@robscott @k8s-ci-robot @youngnick @howardjohn @kflynn @pleshakov @michaelbeaumont @arkodg @shaneutt