Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request mirroring conformance #1912

Merged
merged 9 commits into from
May 17, 2023
Merged

Request mirroring conformance #1912

merged 9 commits into from
May 17, 2023

Conversation

LiorLieberman
Copy link
Member

@LiorLieberman LiorLieberman commented Apr 5, 2023 •
edited
Loading

This PR adds http request mirror conformance test.

Feedback is most welcomed
/cc @robscott
What type of PR is this?
/kind feature
/area conformance

What this PR does / why we need it:
Add tests for request mirroring

Which issue(s) this PR fixes:

Issue #1103

Does this PR introduce a user-facing change?:

- Added: conformance tests for http request mirroring.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 5, 2023
@LiorLieberman
Copy link
Member Author

/retest

robscott
robscott reviewed Apr 5, 2023
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LiorLieberman!

conformance/utils/http/http.go Show resolved Hide resolved
conformance/utils/kubernetes/logs.go Show resolved Hide resolved
conformance/utils/http/mirror.go Outdated Show resolved Hide resolved
@LiorLieberman
Copy link
Member Author

LiorLieberman commented Apr 19, 2023 •
edited
Loading

@robscott @shaneutt PTAL, I still need to think about a few more test cases but this is the general approach

@LiorLieberman
Copy link
Member Author

/retest

@shaneutt shaneutt added this to the v0.8.0 milestone Apr 24, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 25, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 25, 2023
@LiorLieberman
Copy link
Member Author

@robscott @arkodg can you take another look?

arkodg
arkodg approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks !

robscott
robscott reviewed May 3, 2023
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LiorLieberman! Still need to actually run these tests, but the code looks reasonable to me.

conformance/conformance_test.go Show resolved Hide resolved
conformance/base/manifests.yaml Outdated Show resolved Hide resolved
@robscott robscott added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 17, 2023
@robscott
Copy link
Member

Thanks @LiorLieberman!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arkodg, LiorLieberman, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2023
@robscott
Copy link
Member

/cherry-pick release-0.7

@k8s-infra-cherrypick-robot
Copy link

@robscott: once the present PR merges, I will cherry-pick it on top of release-0.7 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@robscott robscott modified the milestones: v0.8.0, v0.7.1 May 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit 34466a8 into kubernetes-sigs:main May 17, 2023
@k8s-infra-cherrypick-robot
Copy link

@robscott: #1912 failed to apply on top of branch "release-0.7":

Applying: add request mirror conformance tests
Using index info to reconstruct a base tree...
M	conformance/utils/http/http.go
M	conformance/utils/suite/suite.go
Falling back to patching base and 3-way merge...
Auto-merging conformance/utils/suite/suite.go
CONFLICT (content): Merge conflict in conformance/utils/suite/suite.go
Auto-merging conformance/utils/http/http.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 add request mirror conformance tests
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-0.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@robscott
Copy link
Member

@LiorLieberman do you mind manually creating a cherry-pick PR to the release-0.7 branch for this?

LiorLieberman added a commit to LiorLieberman/gateway-api that referenced this pull request May 18, 2023
@LiorLieberman
Request mirroring conformance (kubernetes-sigs#1912)
94f8d78 
* add request mirror conformance tests

* add more files

* fix 2023

* added mirrored backend to the base manifests + added logs to ExpectedMirroredRequest

* add newline

* uncomment Suite Features

* fix imports

* remove mirrored-backend from base manifests and reuse existing infra-backend for conformance

* add comment on controller-runtime
@LiorLieberman LiorLieberman mentioned this pull request May 18, 2023
Merged
@LiorLieberman
Copy link
Member Author

Sure, #2034

Just make sure I did it correctly

k8s-ci-robot added a commit that referenced this pull request May 22, 2023
@k8s-ci-robot
Merge pull request #2034 from LiorLieberman/release-0.7
6696019 
[release-0.7] Request mirroring conformance (#1912)
@shaneutt shaneutt mentioned this pull request Jul 24, 2023
Closed
@shaneutt shaneutt mentioned this pull request Aug 7, 2023
Closed
@shaneutt shaneutt mentioned this pull request Sep 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaneutt shaneutt Awaiting requested review from shaneutt

@robscott robscott Awaiting requested review from robscott

@arkodg arkodg Awaiting requested review from arkodg

Assignees

@robscott robscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
No open projects
Gateway API: The Road to GA
Status: Done
Milestone
v0.7.1
Development

Successfully merging this pull request may close these issues.
6 participants
@LiorLieberman @robscott @k8s-ci-robot @k8s-infra-cherrypick-robot @shaneutt @arkodg