Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conformance tests with requestHeaderModifier #2101

Merged
merged 9 commits into from
Jun 23, 2023

Conversation

Treenhan
Copy link
Contributor

@Treenhan Treenhan commented Jun 8, 2023

What type of PR is this?
/kind test
/area conformance

What this PR does / why we need it:
Adding conformance testing by combining one Core Capability (i.e. requestHeaderModifier) wither other Extended Capabilities (i.e. requestMirror, responseHeaderModifier, and urlRewrite)

Which issue(s) this PR fixes:
Fixes #2037

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/test area/conformance labels Jun 8, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 8, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 8, 2023
@k8s-ci-robot k8s-ci-robot requested a review from Xunzhuo June 8, 2023 22:05
@k8s-ci-robot
Copy link
Contributor

Welcome @Treenhan!

It looks like this is your first PR to kubernetes-sigs/gateway-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 8, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @Treenhan. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LiorLieberman
Copy link
Member

/assign @LiorLieberman
/cc @LiorLieberman

Copy link
Member

@LiorLieberman LiorLieberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Treenhan !

Aside from a few small comments looks good.

/ok-to-test

conformance/tests/httproute-redirect-path.yaml Outdated Show resolved Hide resolved
conformance/tests/httproute-response-header-modifier.go Outdated Show resolved Hide resolved
conformance/tests/httproute-response-header-modifier.go Outdated Show resolved Hide resolved
conformance/tests/httproute-response-header-modifier.go Outdated Show resolved Hide resolved
conformance/tests/httproute-rewrite-host.go Outdated Show resolved Hide resolved
conformance/tests/httproute-rewrite-host.yaml Outdated Show resolved Hide resolved
conformance/tests/httproute-rewrite-path.yaml Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 9, 2023
@Xunzhuo
Copy link
Member

Xunzhuo commented Jun 12, 2023

Plz sign CLA first @Treenhan, Thanks!

@Treenhan
Copy link
Contributor Author

Plz sign CLA first @Treenhan, Thanks!

I just created CLA approval request, currently waiting on that to go through

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 13, 2023
@LiorLieberman
Copy link
Member

Thanks @Treenhan
Looks good to me! I ran the tests and everything works as expected.

/lgtm
@robscott can you approve ?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2023
@LiorLieberman
Copy link
Member

/cc @robscott
/assign @robscott

@Treenhan
Copy link
Contributor Author

Hi @robscott could you please take a look?

Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Treenhan! This is great! Nothing blocking here, but a couple small nits. Would appreciate a review from others here as well:

/cc @arkodg @mlavacca @michaelbeaumont @sunjayBhatia @Xunzhuo

Copy link
Member

@sunjayBhatia sunjayBhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test all pass with contour 👍🏽

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2023
@Treenhan
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@Treenhan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gateway-api-verify c8a3718 link true /test pull-gateway-api-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@robscott robscott added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 23, 2023
@robscott
Copy link
Member

Thanks @Treenhan!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, Treenhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit f13c905 into kubernetes-sigs:main Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/test lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conformance: HTTPRoute Filter Combinations
6 participants