-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the route kinds compatible for each protocolType #2263
Document the route kinds compatible for each protocolType #2263
Conversation
Welcome @abs007! |
Hi @abs007. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @abs007!
It looks like you need to run make update-codegen
to fix the CI issue.
Wanted to check if this is what you had in mind when you created #1512
Yep, I meant something similar. However, I'm not 100% sure about the exhaustiveness and the correctness of the data. I think it makes sense to double-check it with the maintainers.
Thanks for laying this out so clearly, @abs007! Seeing it like this, makes me think about the fact that the It's probably also worth checking if we have any conformance tests that don't fit into these buckets too. |
Thank you @youngnick! Can you give a bit more context into the conformance tests bit? |
apis/v1beta1/gateway_types.go
Outdated
// HTTPS: HTTPRoutes, GRPCRoutes | ||
// TCP: TCPRoute | ||
// UDP: UDPRoute | ||
// TLS: TLSRoute |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TLS protocol + TCPRoute should also be supported, right? (ref. https://gateway-api.sigs.k8s.io/guides/tls/ and https://gateway-api.sigs.k8s.io/concepts/api-overview/#route-summary-table)
@youngnick and is this something that I verify by going through the code in the conformance folder? Asking as I'm a bit confused. |
Yeah, I don't think there's any quicker way than to check the conformance tests to make sure we're not allowing any other types of traffic. Sorry. |
That's alright. I just needed confirmation on where to look at. |
I've pushed a protocol:route combination that I could find. |
Can you point out where did you find such a combination, please? |
/remove-lifecycle rotten /approve /hold |
Signed-off-by: Abhisman Sarkar <abhisman.sarkar@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @abs007! this lgtm, if you can rebase it, I think we can merge it 👍
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abs007, shaneutt, youngnick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
We haven't documented some of these changes completely. |
)" This reverts commit a518fef.
…-sigs#2263) * Document the route kinds compatible for each protocolType Signed-off-by: Abhisman Sarkar <abhisman.sarkar@gmail.com> * Add changes Signed-off-by: Abhisman Sarkar <abhisman.sarkar@gmail.com> * Run make command Signed-off-by: Abhisman Sarkar <abhisman.sarkar@gmail.com> * Fix grammar Signed-off-by: Abhisman Sarkar <abhisman.sarkar@gmail.com> * Run make command Signed-off-by: Abhisman Sarkar <abhisman.sarkar@gmail.com> * Add suggested changes Signed-off-by: Abhisman Sarkar <abhisman.sarkar@gmail.com> * chore: run generators --------- Signed-off-by: Abhisman Sarkar <abhisman.sarkar@gmail.com> Co-authored-by: Shane Utt <shaneutt@linux.com>
…bernetes-sigs#2263)" This reverts commit a518fef.
…-sigs#2263) * Document the route kinds compatible for each protocolType Signed-off-by: Abhisman Sarkar <abhisman.sarkar@gmail.com> * Add changes Signed-off-by: Abhisman Sarkar <abhisman.sarkar@gmail.com> * Run make command Signed-off-by: Abhisman Sarkar <abhisman.sarkar@gmail.com> * Fix grammar Signed-off-by: Abhisman Sarkar <abhisman.sarkar@gmail.com> * Run make command Signed-off-by: Abhisman Sarkar <abhisman.sarkar@gmail.com> * Add suggested changes Signed-off-by: Abhisman Sarkar <abhisman.sarkar@gmail.com> * chore: run generators --------- Signed-off-by: Abhisman Sarkar <abhisman.sarkar@gmail.com> Co-authored-by: Shane Utt <shaneutt@linux.com>
…bernetes-sigs#2263)" This reverts commit a518fef.
…-sigs#2263) * Document the route kinds compatible for each protocolType Signed-off-by: Abhisman Sarkar <abhisman.sarkar@gmail.com> * Add changes Signed-off-by: Abhisman Sarkar <abhisman.sarkar@gmail.com> * Run make command Signed-off-by: Abhisman Sarkar <abhisman.sarkar@gmail.com> * Fix grammar Signed-off-by: Abhisman Sarkar <abhisman.sarkar@gmail.com> * Run make command Signed-off-by: Abhisman Sarkar <abhisman.sarkar@gmail.com> * Add suggested changes Signed-off-by: Abhisman Sarkar <abhisman.sarkar@gmail.com> * chore: run generators --------- Signed-off-by: Abhisman Sarkar <abhisman.sarkar@gmail.com> Co-authored-by: Shane Utt <shaneutt@linux.com>
…bernetes-sigs#2263)" This reverts commit a518fef.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
This PR documents the route kinds compatible for each protocolType
Which issue(s) this PR fixes:
Fixes #1515
Does this PR introduce a user-facing change?: