-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CEL validation for listener uniqueness #2370
Conversation
Hi @frankbu. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks @frankbu! Can you add corresponding test(s) in https://github.com/kubernetes-sigs/gateway-api/blob/main/pkg/test/cel/gateway_test.go to ensure this fixes the bug? |
/ok-to-test |
@robscott I added a test, but am wondering if the CEL tests getting run? I don't see them in https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_gateway-api/2370/pull-gateway-api-test/1697659277918867456 |
@frankbu good question! This is decidedly not intuitive, but even though those are go tests, they require a k8s cluster with CRDs installed to be present, so these tests actually are installed in /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: frankbu, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
You can test the CRD validation locally fwiw, we have a package to do so in
Istio somewhere
…On Fri, Sep 1, 2023, 12:27 PM Kubernetes Prow Robot < ***@***.***> wrote:
[APPROVALNOTIFIER] This PR is *APPROVED*
This pull-request has been approved by: *frankbu
<#2370#>*, *robscott
<#2370 (comment)>*
The full list of commands accepted by this bot can be found here
<https://go.k8s.io/bot-commands?repo=kubernetes-sigs%2Fgateway-api>.
The pull request process is described here
<https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process>
Needs approval from an approver in each of these files:
- OWNERS
<https://github.com/kubernetes-sigs/gateway-api/blob/main/OWNERS>
[robscott]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
—
Reply to this email directly, view it on GitHub
<#2370 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEYGXJVT3JQR2ERX6MLPLDXYIZKBANCNFSM6AAAAAA4HZMVPM>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Thanks @frankbu. |
Thanks for this @frankbu. /lgtm @howardjohn, if you can find that package, we should probably create an issue to update this script-based arrangement to something better. (I also have #2362 open to make some changes to it for the YAML-based invalid example tests) |
/cherry-pick release-0.8 |
@robscott: new pull request created: #2379 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
CEL validation not handling missing listener hostname corectly.
Which issue(s) this PR fixes:
Fixes #2369
Does this PR introduce a user-facing change?: