Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPv6 conformance: Third time's the charm #2375

Merged

Conversation

keithmattix
Copy link
Contributor

@keithmattix keithmattix commented Sep 4, 2023

net.SplitHostPort errors if ipv6 addresses aren't in brackets; previous implementation fixed a different problem (SplitHostPort removes brackets if they are passed in)

Fix IPv6 parsing in conformance tests

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 4, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 4, 2023
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
conformance/utils/echo/pod.go Outdated Show resolved Hide resolved
conformance/utils/http/http.go Outdated Show resolved Hide resolved
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
@aojea
Copy link
Contributor

aojea commented Sep 5, 2023

net.SplitHostPort errors if ipv6 addresses aren't in brackets

And that's the expectation , how can you get a host:port without brackets?

@keithmattix
Copy link
Contributor Author

net.SplitHostPort errors if ipv6 addresses aren't in brackets

And that's the expectation , how can you get a host:port without brackets?

Indeed; our mesh conformance tests sometimes pass a raw podIP, so we need to change up the logic a bit

@aojea
Copy link
Contributor

aojea commented Sep 5, 2023

got it, thanks for clarifying 😄

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: howardjohn, keithmattix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@robscott robscott added this to the v0.8.1 milestone Sep 5, 2023
@robscott
Copy link
Member

robscott commented Sep 5, 2023

Thanks @keithmattix! This LGTM, but do you mind adding a release-note block?

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 5, 2023
@keithmattix
Copy link
Contributor Author

Ah thanks for the reminder @robscott. Just added one 👍🏾

@robscott
Copy link
Member

robscott commented Sep 7, 2023

/cherry-pick release-0.8

@k8s-infra-cherrypick-robot

@robscott: once the present PR merges, I will cherry-pick it on top of release-0.8 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
@robscott robscott added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Sep 7, 2023
@robscott
Copy link
Member

robscott commented Sep 7, 2023

Thanks @keithmattix!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit 0f1757e into kubernetes-sigs:main Sep 7, 2023
9 checks passed
@k8s-infra-cherrypick-robot

@robscott: new pull request created: #2381

In response to this:

/cherry-pick release-0.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants