Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move BackendTLSPolicy WellKnownCACerts field to implementation-specific #2741

Conversation

sunjayBhatia
Copy link
Member

What type of PR is this?

/kind cleanup
/kind documentation

What this PR does / why we need it:

Changes WellKnownCACerts field of BackendTLSPolicy to Implementation-specific support

Also updates language around what to do if WellKnownCACerts is not supported

Which issue(s) this PR fixes:

Fixes #2726

Does this PR introduce a user-facing change?:

BackendTLSPolicy WellKnownCACerts field has been updated to implementation-specific support

Also updates language around what to do if WellKnownCACerts is not supported

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 26, 2024
@youngnick
Copy link
Contributor

This is a good change, thanks @sunjayBhatia.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2024
@robscott
Copy link
Member

Not sure how I missed this one, thanks @sunjayBhatia!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, sunjayBhatia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2024
@k8s-ci-robot k8s-ci-robot merged commit e854f36 into kubernetes-sigs:main Feb 22, 2024
8 checks passed
@sunjayBhatia sunjayBhatia deleted the backendtlspolicy-wellknown-system-impl-specific branch February 27, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BackendTLSPolicy wellKnownCACerts field "System" value should not be core
4 participants