Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing columns to gwctl get policycrds #2811

Conversation

jongwooo
Copy link
Member

What type of PR is this?

/kind feature
/area gwctl
/cc @gauravkghildiyal

What this PR does / why we need it:

Add missing columns to gwctl get policycrds.

Output Columns Description Visibility
NAME Name of the Policy CRD in the form <kind.group>
POLICY TYPE Type of policy defined by the CRD (Inherited or Direct)
SCOPE Scope of the policy (Namespaced or Cluster)
POLICIES COUNT Count of policy resources of this particular type. -o wide
AGE Age of the Policy CRD

Which issue(s) this PR fixes:

Fixes #2810

Does this PR introduce a user-facing change?:

Add missing columns to `gwctl get policycrds`

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. area/gwctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 26, 2024
@jongwooo jongwooo force-pushed the add-missing-columns-to-gwctl-get-policycrds branch 2 times, most recently from 2f15a63 to 08cec5a Compare February 26, 2024 08:06
@gauravkghildiyal
Copy link
Member

/assign

@jongwooo jongwooo marked this pull request as draft February 27, 2024 00:12
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 27, 2024
@jongwooo
Copy link
Member Author

jongwooo commented Mar 6, 2024

I'll work on this once #2808 is merged.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 6, 2024
Signed-off-by: Jongwoo Han <jongwooo.han@gmail.com>
@jongwooo jongwooo force-pushed the add-missing-columns-to-gwctl-get-policycrds branch from 08cec5a to 252000d Compare March 7, 2024 01:47
@jongwooo jongwooo marked this pull request as ready for review March 7, 2024 01:48
@k8s-ci-robot k8s-ci-robot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 7, 2024
@gauravkghildiyal
Copy link
Member

Thanks @jongwooo

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauravkghildiyal, jongwooo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit efa7f51 into kubernetes-sigs:main Mar 8, 2024
8 checks passed
@jongwooo jongwooo deleted the add-missing-columns-to-gwctl-get-policycrds branch March 8, 2024 10:03
hanxiaop pushed a commit to hanxiaop/gateway-api that referenced this pull request Mar 13, 2024
Signed-off-by: Jongwoo Han <jongwooo.han@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/gwctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing columns to gwctl get policycrds
3 participants