Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement gwctl get namespace #2865

Merged

Conversation

jongwooo
Copy link
Member

What type of PR is this?

/kind feature
/area gwctl
/cc @gauravkghildiyal

What this PR does / why we need it:

Implement gwctl get namespace.

Output Columns Description Visibility
NAME Name of the Namespace
STATUS Status of the Namespace
AGE Age of the Namespace
POLICIES Count of policies affecting this Namespace -o wide

The -o wide format is not yet implemented, so the column POLICIES is excluded.

Which issue(s) this PR fixes:

Fixes #2854

Does this PR introduce a user-facing change?:

Implement `gwctl get namespace`

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. area/gwctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 12, 2024
@gauravkghildiyal
Copy link
Member

/assign

gwctl/cmd/get.go Outdated Show resolved Hide resolved
@jongwooo jongwooo force-pushed the implement-gwctl-get-namespace branch from 6976b74 to 2a1979b Compare March 22, 2024 03:49
@jongwooo
Copy link
Member Author

jongwooo commented Mar 22, 2024

The following test failed

It seems that the describe command also needs sorting (by name).

@shaneutt shaneutt requested a review from mlavacca March 22, 2024 08:07
@jongwooo jongwooo force-pushed the implement-gwctl-get-namespace branch from 2a1979b to 5b05a56 Compare March 28, 2024 05:58
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 28, 2024
@jongwooo jongwooo marked this pull request as draft March 28, 2024 06:05
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 28, 2024
@jongwooo jongwooo force-pushed the implement-gwctl-get-namespace branch from 5b05a56 to 79333e3 Compare March 28, 2024 06:13
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 28, 2024
@jongwooo jongwooo marked this pull request as ready for review March 28, 2024 06:14
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 28, 2024
@gauravkghildiyal
Copy link
Member

Thanks @jongwooo

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauravkghildiyal, jongwooo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit 18ad4ba into kubernetes-sigs:main Mar 29, 2024
8 checks passed
@jongwooo jongwooo deleted the implement-gwctl-get-namespace branch March 29, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/gwctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement gwctl get namespace
3 participants