fix(gwctl): prevent panic when describing gatewayclasses with no description

[pmalek]

What type of PR is this?

/kind bug
/area gwctl

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #2849

Does this PR introduce a user-facing change?:

fix(gwctl): prevent panic when describing gatewayclasses with no description

[k8s-ci-robot]

Hi @pmalek. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gauravkghildiyal]

/assign

[gauravkghildiyal]

Thanks for the fix @pmalek. Just one minor thought :) (Open for discussion)

[gauravkghildiyal]

nit: Is it more neat if we simply convert Description to a *string and just directly assign:

Description: gatewayClassNode.GatewayClass.Spec.Description

Alternatively, if we really don't want a pointer, maybe the following is still slightly neater (since it keeps ControllerName out of the conditional)?

		views := []gatewayClassDescribeView{
			{
				Name: gatewayClassNode.GatewayClass.GetName(),
			},
			{
				ControllerName: string(gatewayClassNode.GatewayClass.Spec.ControllerName),
			},
		}

		if desc := gatewayClassNode.GatewayClass.Spec.Description; desc != nil {
			views = append(views, gatewayClassDescribeView{Description: *desc})
		}

[pmalek]

I didn't want to change the type but sure, why not. 9cd09fb

[gauravkghildiyal]

Thank you for accommodating!

[gauravkghildiyal]

/ok-to-test
/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauravkghildiyal, pmalek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• gwctl/OWNERS [gauravkghildiyal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gauravkghildiyal]

/hold

[gauravkghildiyal]

/label tide/merge-method-squash

[gauravkghildiyal]

/unhold

[pmalek]

@gauravkghildiyal I've fixed the test that was failing. PTAL

[gauravkghildiyal]

Thank you!

/lgtm