Upgrading to go 1.22 + k8s 1.30 dependencies #2988

robscott · 2024-04-18T01:32:55Z

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Kubernetes v1.30 was released today, this bumps dependencies to match.

Which issue(s) this PR fixes:
Fixes #2956

Does this PR introduce a user-facing change?:

Dependencies have been updated to use Go 1.22 and Kubernetes 1.30.

howardjohn · 2024-04-18T01:54:01Z

go.mod

@@ -1,23 +1,23 @@
 module sigs.k8s.io/gateway-api

-go 1.21
+go 1.22.2


there's no need to require .2 (I think)

this is viral and will force all dependencies to do so as well

I think it's automatic now, go mod tidy will hardcode 1.22.0 if we just have 1.22 here. Maybe that's preferable? (x-ref https://github.com/kubernetes/kubernetes/blob/master/go.mod#L9)

yeah I would put 1.22.0.

1.22.2 says "you MUST have the .2 patch to use this as a library". Really the Go specifier should be the minimum version you support (though in practice this doesn't matter much since the go ecosystem is pretty good about updating)

Controversial...

https://twitter.com/liggitt/status/1780994018047840540
kubernetes/kubernetes#124385

Yeah I've complained here - golang/go#65847

It seems like upstream is moving to 1.22.2 for now (x-ref kubernetes/kubernetes#124386), will stick with this until a better option emerges.

I closed kubernetes/kubernetes#124386 until we think through this more and left k/k at 1.22.0, xref kubernetes/kubernetes#124386 (comment)

I'd recommend go 1.22.0 or whatever go dictates your minimum has to be ... including the patch means you won't fight go tooling, leaving it at the minimum patch in the minor means you are permissive to your downstreams and builders as possible

Building with go patch versions above the minimum works perfectly well (and you can actually put toolchain directives in the go.mod file to indicate you require building main packages in this module with a higher patch version if you want)

Updated to use 1.22.0, thanks everyone!

howardjohn · 2024-04-18T01:55:35Z

go.mod

 	k8s.io/utils v0.0.0-20240102154912-e7106e64919e
-	sigs.k8s.io/controller-runtime v0.16.3
+	sigs.k8s.io/controller-runtime v0.17.3


surprised this works since they don't support 1.30 yet and there were incompatible changes.. I guess we must not import some of those packages

Bumped back to v0.17.0 to allow dependent implementations to pick up newer changes from controller-runtime - no changes in either case from perspective of Gateway API directly.

hack/update-codegen.sh

robscott · 2024-04-18T21:04:37Z

Looks like any use of applyconfiguration-gen is broken until kubernetes/kubernetes#124371 merges (ideally in time for v1.30.1). That leaves us with a few not-great options:

Release RC1 without applyconfigurations
Release RC1 without k8s 1.30 + go 1.22
Wait for k8s v1.30.1 until releasing RC1

At this point, I'm thinking that if v1.30.1 is not ready (or close to ready) by the time we're ready to release RC1, we should move forward with option 1 with the idea that we might be able to add applyconfigurations back in before RC2 (cc @dprotaso).

dprotaso · 2024-04-18T21:30:31Z

The docker images need bumping to go 1.22 as well - see #2993

robscott · 2024-04-19T00:31:39Z

Looks like any use of applyconfiguration-gen is broken until kubernetes/kubernetes#124371 merges (ideally in time for v1.30.1). That leaves us with a few not-great options:

Release RC1 without applyconfigurations

Release RC1 without k8s 1.30 + go 1.22

Wait for k8s v1.30.1 until releasing RC1

Thanks to some clever hacks by @dprotaso, we've got a workaround that should work until the upstream fix is released in v1.30.1. This PR is ready for another round of review.

robscott · 2024-04-22T21:43:56Z

The docker images need bumping to go 1.22 as well - see #2993

Updated, thanks @dprotaso!

dprotaso · 2024-04-22T22:59:59Z

/retest

shaneutt · 2024-04-23T10:03:54Z

I think it would be nice if we could get this in for 1.1.

robscott · 2024-04-23T21:26:51Z

I think @k8s-ci-robot needs some help clearing the needs-rebase label,

/honk

k8s-ci-robot · 2024-04-23T21:26:54Z

@robscott:

In response to this:

I think @k8s-ci-robot needs some help clearing the needs-rebase label,

/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Co-authored-by: Dave Protasowski <dprotaso@gmail.com>

k8s-ci-robot · 2024-04-23T23:22:54Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: howardjohn, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [robscott]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

howardjohn · 2024-04-23T23:22:58Z

/lgtm

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 18, 2024

k8s-ci-robot requested review from danwinship and thockin April 18, 2024 01:33

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 18, 2024

robscott added this to the v1.1.0 milestone Apr 18, 2024

howardjohn reviewed Apr 18, 2024

View reviewed changes

robscott force-pushed the go-1-22 branch from c2fe68f to 6b0f7f0 Compare April 18, 2024 17:12

k8s-ci-robot added the area/gwctl label Apr 18, 2024

robscott force-pushed the go-1-22 branch 2 times, most recently from 6ee70e6 to 6eeee6a Compare April 18, 2024 18:56

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 18, 2024

robscott commented Apr 18, 2024

View reviewed changes

hack/update-codegen.sh Show resolved Hide resolved

robscott force-pushed the go-1-22 branch from 6eeee6a to 370fc59 Compare April 18, 2024 20:15

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 18, 2024

robscott force-pushed the go-1-22 branch from 370fc59 to cfe1379 Compare April 18, 2024 20:33

robscott mentioned this pull request Apr 18, 2024

Automated cherry pick of #123893: kube_codegen: expose applyconfig-openapi-schema flag for #124193: Update applyconfig-gen for pacakges where group and dir kubernetes/kubernetes#124371

Merged

dprotaso mentioned this pull request Apr 18, 2024

Bump Go version to 1.22 #2993

Closed

robscott mentioned this pull request Apr 18, 2024

Adding changelog for v1.1.0-rc1 #2967

Merged

robscott force-pushed the go-1-22 branch 2 times, most recently from bc726c7 to e22f237 Compare April 19, 2024 00:11

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 19, 2024

robscott force-pushed the go-1-22 branch from e22f237 to 7072814 Compare April 19, 2024 00:29

This was referenced Apr 22, 2024

build(deps): bump the k8s-io group with 6 updates #3002

Closed

build(deps): bump the k8s-io group in /gwctl with 4 updates #3008

Closed

robscott force-pushed the go-1-22 branch 3 times, most recently from b04c765 to d74fd80 Compare April 22, 2024 21:43

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 23, 2024

robscott force-pushed the go-1-22 branch from d74fd80 to 627c31e Compare April 23, 2024 21:08

This was referenced Apr 23, 2024

build(deps): bump sigs.k8s.io/controller-runtime from 0.17.2 to 0.17.3 in /gwctl #2978

Closed

build(deps): bump google.golang.org/grpc from 1.61.0 to 1.63.2 #2976

Closed

build(deps): bump sigs.k8s.io/controller-runtime from 0.16.3 to 0.17.3 #2975

Closed

robscott force-pushed the go-1-22 branch 2 times, most recently from 04937dc to 01aae89 Compare April 23, 2024 22:25

Upgrading to go 1.22 + k8s 1.30 dependencies

27d317c

Co-authored-by: Dave Protasowski <dprotaso@gmail.com>

robscott force-pushed the go-1-22 branch from 01aae89 to 27d317c Compare April 23, 2024 23:21

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 23, 2024

howardjohn approved these changes Apr 23, 2024

View reviewed changes

k8s-ci-robot assigned howardjohn Apr 23, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2024

k8s-ci-robot merged commit 12d50fe into kubernetes-sigs:main Apr 23, 2024
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrading to go 1.22 + k8s 1.30 dependencies #2988

Upgrading to go 1.22 + k8s 1.30 dependencies #2988

robscott commented Apr 18, 2024

howardjohn Apr 18, 2024

robscott Apr 18, 2024

howardjohn Apr 18, 2024

howardjohn Apr 18, 2024

dprotaso Apr 18, 2024

robscott Apr 18, 2024

liggitt Apr 19, 2024

liggitt Apr 19, 2024 •

edited

Loading

robscott Apr 22, 2024

howardjohn Apr 18, 2024

robscott Apr 23, 2024

robscott commented Apr 18, 2024 •

edited

Loading

dprotaso commented Apr 18, 2024

robscott commented Apr 19, 2024

robscott commented Apr 22, 2024

dprotaso commented Apr 22, 2024

shaneutt commented Apr 23, 2024

robscott commented Apr 23, 2024

k8s-ci-robot commented Apr 23, 2024

k8s-ci-robot commented Apr 23, 2024

howardjohn commented Apr 23, 2024

Upgrading to go 1.22 + k8s 1.30 dependencies #2988

Upgrading to go 1.22 + k8s 1.30 dependencies #2988

Conversation

robscott commented Apr 18, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liggitt Apr 19, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

robscott commented Apr 18, 2024 • edited Loading

dprotaso commented Apr 18, 2024

robscott commented Apr 19, 2024

robscott commented Apr 22, 2024

dprotaso commented Apr 22, 2024

shaneutt commented Apr 23, 2024

robscott commented Apr 23, 2024

k8s-ci-robot commented Apr 23, 2024

k8s-ci-robot commented Apr 23, 2024

howardjohn commented Apr 23, 2024

liggitt Apr 19, 2024 •

edited

Loading

robscott commented Apr 18, 2024 •

edited

Loading