Properly handle different versioned resources in gwctl (eg. v1beta1 v/s v1 APIs) and related code cleanups #3001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
cncf-cla: yes
|
/cc @mlavacca |
k8s-ci-robot
added
the
needs-rebase
gauravkghildiyal
force-pushed
the
api-version-fix
branch
from
3c51c51
to
6cf42ae
Compare
k8s-ci-robot
removed
the
needs-rebase
gauravkghildiyal
force-pushed
the
api-version-fix
branch
2 times, most recently
from
c172d6d
to
a9369f8
Compare
The dynamic client returned for unit tests may not be smart enough to automatically guess the APIVersion and Kind (which the real kube-apiserver can handle automatically). To get over this, we can simply simply include these when creating the objects.
gauravkghildiyal
force-pushed
the
api-version-fix
branch
2 times, most recently
from
3f7ef46
to
6c18bf8
Compare
|
/retest |
… API types. Clusters may not always have the v1 CRDs installed. This means gwctl will have to use whatever version is available in the cluster. Hence, we will use API Discovery to determine the "preferred" API version as per the kube-apiserver and then use a dynamic client to fetch that specific versioned resource. Once that specific versioned resource is fetched (e.g. v1beta1.Gateway), it will be converted to a concrete type used within gwctl (eg. v1.Gateway), which will usually be a more newer/stable version. For most cases, this conversion should not result in any losses. If in the future, a need arises for such special cases, we should be able to extend the approach by configuring some conversion functions (eg. conversion function for v1beta1.Gateway -> v1.Gateway).
gauravkghildiyal
force-pushed
the
api-version-fix
branch
from
6c18bf8
to
9d9aa93
Compare
robscott
approved these changes
May 2, 2024
There was a problem hiding this comment.
Thanks @gauravkghildiyal, this looks like a great addition!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauravkghildiyal, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…Gateway API types.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Use API discovery to determine the preferred API versions for Gateway API types.
Clusters may not always have the v1 CRDs installed. This means gwctl will have
to use whatever version is available in the cluster. Hence, we will use API
Discovery to determine the "preferred" API version as per the kube-apiserver and
then use a dynamic client to fetch that specific versioned resource.
Once that specific versioned resource is fetched (e.g. v1beta1.Gateway), it will
be converted to a concrete type used within gwctl (eg. v1.Gateway), which will
usually be a more newer/stable version. For most cases, this conversion should
not result in any losses. If in the future, a need arises for such special
cases, we should be able to extend the approach by configuring some conversion
functions (eg. conversion function for v1beta1.Gateway -> v1.Gateway).
Which issue(s) this PR fixes:
Fixes #3000
Does this PR introduce a user-facing change?:
/area gwctl