Conformance test for listener isolation #3047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/test
do-not-merge/release-note-label-needed
k8s-ci-robot
added
the
size/L
|
Thanks @arkodg! Mind adding @pleshakov as a co-author on the commit? |
Takes kubernetes-sigs#2669 forward Signed-off-by: Arko Dasgupta <arko@tetrate.io> Co-authored-by: Michael Pleshakov <m.pleshakov@f5.com>
|
thanks for pointing that out @robscott, done |
robscott
reviewed
May 2, 2024
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
|
Thanks @arkodg! Mind filing a follow up issue to track refactoring this test to use a single Gateway? /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arkodg, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/release-note-none |
k8s-ci-robot
added
release-note-none
|
fwiw istio is failing this new test. Could be our fault, ill investigate tomorrow. wanted to bring it up since it's a last minute rc2 change @robscott |
sayboras
added a commit
to cilium/cilium
that referenced
this pull request
Jun 6, 2024
This commit is to support Listener Isolation concept from the upstream, which allows at most one Listener matches a request, and only Routes attached to that Listener are used for routing. Relates: kubernetes-sigs/gateway-api#2465 Relates: kubernetes-sigs/gateway-api#3047 Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
added a commit
to cilium/cilium
that referenced
this pull request
Jun 6, 2024
This commit is to support Listener Isolation concept from the upstream, which allows at most one Listener matches a request, and only Routes attached to that Listener are used for routing. Relates: kubernetes-sigs/gateway-api#2465 Relates: kubernetes-sigs/gateway-api#3047 Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
added a commit
to cilium/cilium
that referenced
this pull request
Jun 7, 2024
This commit is to support Listener Isolation concept from the upstream, which allows at most one Listener matches a request, and only Routes attached to that Listener are used for routing. Relates: kubernetes-sigs/gateway-api#2465 Relates: kubernetes-sigs/gateway-api#3047 Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
added a commit
to cilium/cilium
that referenced
this pull request
Jun 7, 2024
This commit is to support Listener Isolation concept from the upstream, which allows at most one Listener matches a request, and only Routes attached to that Listener are used for routing. Relates: kubernetes-sigs/gateway-api#2465 Relates: kubernetes-sigs/gateway-api#3047 Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
added a commit
to cilium/cilium
that referenced
this pull request
Jun 7, 2024
This commit is to support Listener Isolation concept from the upstream, which allows at most one Listener matches a request, and only Routes attached to that Listener are used for routing. Relates: kubernetes-sigs/gateway-api#2465 Relates: kubernetes-sigs/gateway-api#3047 Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
added a commit
to cilium/cilium
that referenced
this pull request
Jun 11, 2024
This commit is to support Listener Isolation concept from the upstream, which allows at most one Listener matches a request, and only Routes attached to that Listener are used for routing. Relates: kubernetes-sigs/gateway-api#2465 Relates: kubernetes-sigs/gateway-api#3047 Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
added a commit
to cilium/cilium
that referenced
this pull request
Jun 11, 2024
This commit is to support Listener Isolation concept from the upstream, which allows at most one Listener matches a request, and only Routes attached to that Listener are used for routing. Relates: kubernetes-sigs/gateway-api#2465 Relates: kubernetes-sigs/gateway-api#3047 Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
added a commit
to cilium/cilium
that referenced
this pull request
Jun 13, 2024
This commit is to support Listener Isolation concept from the upstream, which allows at most one Listener matches a request, and only Routes attached to that Listener are used for routing. Relates: kubernetes-sigs/gateway-api#2465 Relates: kubernetes-sigs/gateway-api#3047 Signed-off-by: Tam Mach <tam.mach@cilium.io>
github-merge-queue bot
pushed a commit
to cilium/cilium
that referenced
this pull request
Jun 13, 2024
This commit is to support Listener Isolation concept from the upstream, which allows at most one Listener matches a request, and only Routes attached to that Listener are used for routing. Relates: kubernetes-sigs/gateway-api#2465 Relates: kubernetes-sigs/gateway-api#3047 Signed-off-by: Tam Mach <tam.mach@cilium.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Takes #2669 forward
Which issue(s) this PR fixes:
Fixes # #2416
/kind test
/area conformance
Does this PR introduce a user-facing change?: