-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix v1beta1 HTTPHeaderName alias #3127
Fix v1beta1 HTTPHeaderName alias #3127
Conversation
Currently, the v1beta1 HTTPHeaderName aliases directly to v1.HeaderName instead of v1.HTTPHeaderName (which then aliases to v1.HeaderName).
/assign @robscott |
Not sure if this should be |
Thanks @spencerhance! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott, spencerhance The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Currently, the v1beta1 HTTPHeaderName aliases directly to v1.HeaderName instead of v1.HTTPHeaderName (which then aliases to v1.HeaderName).
Currently, the v1beta1 HTTPHeaderName aliases directly to v1.HeaderName instead of v1.HTTPHeaderName (which then aliases to v1.HeaderName).
What type of PR is this?
/kind bug
What this PR does / why we need it:
Currently, the v1beta1 HTTPHeaderName aliases directly to v1.HeaderName instead of v1.HTTPHeaderName (which then aliases to v1.HeaderName).
Does this PR introduce a user-facing change?: