-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change report API version #3153
fix: change report API version #3153
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mlavacca The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @mlavacca! LGTM once gofumpt check passes |
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
c947146
to
947f3d6
Compare
It's fixed now, PTAL :) |
/lgtm |
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
What type of PR is this?
/kind bug
/area conformance
What this PR does / why we need it:
With the graduation of the conformance test suite we bumped the
ConformanceReport
API to v1. However, we did not change theAPIVersion
of the reports created by the suite accordingly. The result was that we were creating v1 reports with v1alpha1 set asAPIVersion
. This PR fixes such a problem.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: