Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix cilium conformance report #3168

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

mlavacca
Copy link
Member

@mlavacca mlavacca commented Jun 19, 2024

What type of PR is this?

/kind documentation

What this PR does / why we need it:

#3137 added a new conformance report for Cilium. The report and the README were malformed in the following way:

  • the link to the report in the README was broken
  • the link to the cilium release was broken; Cilium v1.16.0 has not been released at the moment of writing yet, therefore I've set here the rc1 link.
  • the version of the report was not set and instead was "main". Since the report was for Cilium version 1.16.0, I changed it to 1.16.0.

Once Cilium 1.16.0 gets released, we need to update this report again with the GH link to the new release.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 19, 2024
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 19, 2024
@mlavacca
Copy link
Member Author

@sayboras, please would you be able to update this README with the v1.16.0 release link once it gets released?

Copy link
Contributor

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mlavacca, sayboras

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sayboras
Copy link
Contributor

please would you be able to update this README with the v1.16.0 release link once it gets released?

Noted and thanks for the ping.

@robscott
Copy link
Member

Thanks @mlavacca!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2024
@k8s-ci-robot k8s-ci-robot merged commit 6b609e0 into kubernetes-sigs:main Jun 20, 2024
8 checks passed
BobyMCbobs pushed a commit to BobyMCbobs/kubernetes-sigs-gateway-api that referenced this pull request Jul 10, 2024
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
BobyMCbobs pushed a commit to BobyMCbobs/kubernetes-sigs-gateway-api that referenced this pull request Jul 22, 2024
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
BobyMCbobs pushed a commit to BobyMCbobs/kubernetes-sigs-gateway-api that referenced this pull request Jul 22, 2024
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants