-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gwctl] Expand the output of gwctl describe httproute #3181
[gwctl] Expand the output of gwctl describe httproute #3181
Conversation
@gauravkghildiyal: GitHub didn't allow me to request PR reviews from the following users: tdn21. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
f27a963
to
359efad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, @gauravkghildiyal!
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauravkghildiyal, mlavacca The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR builds upon the great work by @tdn21 in #3071. I've rebased, added a new commit adding the requested tests and made some minor changes.
Which issue(s) this PR fixes:
Fixes #3037
Does this PR introduce a user-facing change?:
/assign @mlavacca
/cc @tdn21