Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gwctl] Expand the output of gwctl describe httproute #3181

Merged
merged 4 commits into from
Jul 22, 2024

Conversation

gauravkghildiyal
Copy link
Member

@gauravkghildiyal gauravkghildiyal commented Jul 3, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR builds upon the great work by @tdn21 in #3071. I've rebased, added a new commit adding the requested tests and made some minor changes.

Which issue(s) this PR fixes:

Fixes #3037

Does this PR introduce a user-facing change?:

The output of `gwctl describe httproute <NAME>` now includes more details

/assign @mlavacca
/cc @tdn21

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jul 3, 2024
@k8s-ci-robot
Copy link
Contributor

@gauravkghildiyal: GitHub didn't allow me to request PR reviews from the following users: tdn21.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR builds upon the great work by @tdn21 in #3071. I've added a new commit adding the requested tests and some other minor cleanups.

Which issue(s) this PR fixes:

Fixes #3037

Does this PR introduce a user-facing change?:

The output of `gwctl describe httproute <NAME>` now includes more details

/assign @mlavacca
/cc @tdn21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/gwctl approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 3, 2024
Copy link
Member

@mlavacca mlavacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @gauravkghildiyal!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauravkghildiyal, mlavacca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 19e3a7c into kubernetes-sigs:main Jul 22, 2024
8 checks passed
@gauravkghildiyal gauravkghildiyal deleted the pr/tdn21/3071 branch July 23, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/gwctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand output for gwctl describe httproutes
4 participants