-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: deduplicate Declined status #3238
Conversation
Welcome @xmulligan! |
Hi @xmulligan. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Thanks @xmulligan! 🙂 /ok-to-test |
I don't really see how this change could be breaking anything... /retest |
/retest |
Yeah, looks like there's some issue with netlify building. Weird. /approve |
deduplicate Declined status
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shaneutt, xmulligan, youngnick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
deduplicate Declined status
What type of PR is this?
/kind cleanup
/kind documentation
What this PR does / why we need it:
declined status is listed twice so I'm combining them into one
Does this PR introduce a user-facing change?: