Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix conformance test race condition #3350

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Fix conformance test race condition #3350

merged 1 commit into from
Sep 20, 2024

Conversation

caboteria
Copy link
Contributor

We had two tests that used an HTTPRoute called "http-route-4" which caused flaky tests because the first test's delete can (and sometimes does) happen after the second test's create, which means that the order of operations was:

  1. create http-route-4
  2. run first test
  3. cleanup first test - queue a delete of http-route-4
  4. set up second test - what should have been a create of http-route-4 becomes an update
  5. delete from first test deletes http-route-4
  6. second test fails

What type of PR is this?
/kind bug
/kind failing-test

What this PR does / why we need it:
This is a rebase of #3348 onto the main branch.

Which issue(s) this PR fixes:
Fixes #

Does this PR introduce a user-facing change?:

NONE

@caboteria
Fix conformance test race condition
557c265 
We had two tests that used an HTTPRoute called "http-route-4" which
caused flaky tests because the first test's delete can (and sometimes
does) happen after the second test's create, which means that the
order of operations was:

1. create http-route-4
1. run first test
1. cleanup first test - queue a delete of http-route-4
1. set up second test - what should have been a create of http-route-4 becomes an update
1. delete from first test deletes http-route-4
1. second test fails
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 20, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @caboteria. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 20, 2024
@arkodg
Copy link
Contributor

arkodg commented Sep 20, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 20, 2024
@arkodg
Copy link
Contributor

arkodg commented Sep 20, 2024

/approve

cc @robscott

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arkodg, caboteria

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2024
@robscott robscott mentioned this pull request Sep 20, 2024
Closed
@robscott
Copy link
Member

Thanks @caboteria!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2024
@k8s-ci-robot k8s-ci-robot merged commit 401eb26 into kubernetes-sigs:main Sep 20, 2024
13 checks passed
sayboras added a commit to cilium/cilium that referenced this pull request Sep 26, 2024
@sayboras
gateway-api: Sync up with latest version upstream
b71311d 
The main goal is to avoid some flakes with below PR

Relates: kubernetes-sigs/gateway-api#3350
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras mentioned this pull request Sep 26, 2024
Merged
github-merge-queue bot pushed a commit to cilium/cilium that referenced this pull request Sep 26, 2024
@sayboras
gateway-api: Sync up with latest version upstream
ec1787b 
The main goal is to avoid some flakes with below PR

Relates: kubernetes-sigs/gateway-api#3350
Signed-off-by: Tam Mach <tam.mach@cilium.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn Awaiting requested review from howardjohn

@michaelbeaumont michaelbeaumont Awaiting requested review from michaelbeaumont

Assignees

@robscott robscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@caboteria @k8s-ci-robot @arkodg @robscott